Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure] remove feature gates since CAPI is as default install #55394

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[azure] remove feature gates since CAPI is as default install #55394

merged 1 commit into from
Aug 15, 2024

Conversation

jinyunma
Copy link
Contributor

@jinyunma jinyunma commented Aug 9, 2024

https://issues.redhat.com/browse/CORS-3356

Remove feature gate because CAPI install is as default via installer PR#openshift/installer#8809

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jinyunma: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-ipi-proxy-workers-rhcos-rhel8-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-basecap-vset-arm-f2 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-ipi-disc-oidc-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-azure-ipi-oidc-managed-identity-user-defined-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-azure-ipi-marketplace-image-gen1-vm-type-gen1-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-ovn-etcd-encryption-compact-arm-f2 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-fullyprivate-internal-registry-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-azure-ipi-private-sshkey-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-azure-ipi-disktype-premium-lrs-disksize-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-private-spec-net-type-spec-perm-arm-f2 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-ipi-proxy-workers-rhcos-rhel8-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-private-spec-net-type-spec-perm-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-usertags-sa-encryption-arm-f5 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-des-day2-arm-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-ipi-f9-longduration-part3-3 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-azure-ipi-oidc-managed-identity-system-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-des-mini-perm-fips-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-ultrassd-disks-arm-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-arm64-nightly-azure-ipi-private-f28-disasterrecovery N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-fullyprivate-proxy-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-arm64-nightly-azure-ipi-longduration-reliability-test-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-ipi-disc-oidc-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-basecap-vset-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-azure-ipi-des-day2-fips-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-ipi-marketplace-mini-perm-f5 N/A periodic Ci-operator config changed

A total of 56 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jinyunma
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-azure-ipi-disktype-standardssd-lrs-disksize-f14

@openshift-ci-robot
Copy link
Contributor

@jinyunma: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jinyunma jinyunma changed the title WIP: [azure] remove feature gates since CAPI is as default install [azure] remove feature gates since CAPI is as default install Aug 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2024
@jinyunma
Copy link
Contributor Author

/pj-rehearse ack

cc @jianlinliu @gpei to review

@openshift-ci-robot
Copy link
Contributor

@jinyunma: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 15, 2024
@gpei
Copy link
Contributor

gpei commented Aug 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@jianlinliu
Copy link
Contributor

/lgtm

@jinyunma
Copy link
Contributor Author

cc @liangxia to review

@liangxia
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei, jianlinliu, jinyunma, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@jinyunma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9b552a0 into openshift:master Aug 15, 2024
16 checks passed
@jinyunma jinyunma deleted the azure_417_featuregate branch August 15, 2024 04:22
jadhaj pushed a commit to jadhaj/release that referenced this pull request Aug 18, 2024
@jinyunma @jadhaj
[azure] remove feature gates since CAPI is as default install (opensh…
ff910bd 
…ift#55394)
jadhaj pushed a commit to jadhaj/release that referenced this pull request Aug 18, 2024
@jinyunma @jadhaj
[azure] remove feature gates since CAPI is as default install (opensh…
cf6787e 
…ift#55394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis016 dis016 Awaiting requested review from dis016

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@jianlinliu jianlinliu

@gpei gpei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jinyunma @openshift-ci-robot @gpei @jianlinliu @liangxia @openshift-merge-robot