[wip] Handle failed CloudPrivateIPConfig assignments #2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
kyrtapz
force-pushed
the
ds_handle_failed_cpic
branch
2 times, most recently
from
8c307fe to
6a7d141
Compare
When a CPIC is created and the cloud controller externally sets its status to Failed because the node no longer exists ovn-k should clean it up. Reproducer: 1. CPIC assignment fails because the node was removed after the object was created but before it was sucessfully assigned in cloud. 2. The EgressIP status never reflects it as it ignores non-sucessfull assignments 3. Later reconciliation attempts trying to create the same CPIC again 4. Creation failures due to "already exists" errors To fix the issue remove failed CPICs during CPIC add reconciliation. Signed-off-by: Patryk Diak <[email protected]>
kyrtapz
force-pushed
the
ds_handle_failed_cpic
branch
from
6a7d141 to
d7aedb8
Compare
In a scenario when during CPIC removal the EIP controller wants to assign it again we were missing a reconciliation attempt after the removal succeded. Signed-off-by: Patryk Diak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS test for https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5649/files