SREP-2594: Fix osdctl promote --hotfix failing to find app.yml #822
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
tide/merge-method-squash
|
@MateSaary: This pull request references SREP-2594 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MateSaary The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Add test coverage for path resolution logic across different directory structures (services, osd-operators, backplane) to ensure app.yml files are correctly located for hotfix promotions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
@MateSaary: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This PR fixes specific operators such as
managed-cluster-configfailing to be hotfix-promoted due to nested directory structures (e.g.,data/services/osd-operators/{component}/app.yml) not being handled by the previous flat path assumption.The fix derives
app.ymlpaths by parsing the saas file's directory structure to detect nested vs flat layouts. As a defensive guardrail, fallback logic performs filesystem searching in expected paths if the derived path doesn't exist. The functions have been extracted to a newpathutilpackage to avoid code duplication./label tide/merge-method-squash