Updating the cluster search query #770
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chamalabey The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@chamalabey: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| } | ||
| clusters, err := utils.ApplyFilters( | ||
| ocmClient, | ||
| []string{fmt.Sprintf("name like '%s%%'", clusterName)}, |
There was a problem hiding this comment.
@chamalabey do you know why we're not directly returning the output from this?
There was a problem hiding this comment.
@typeid Is it possible for this call to return more than one result (list of clusters)? Line 80 is handling this scenario in a for loop. Either way we might need to check whether if there is more than one result and return only one. Please let me know your thought ?
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
/remove-lifecycle rotten |
openshift-ci
bot
removed
the
lifecycle/rotten
3 participants
Fix the issue raised here https://redhat-internal.slack.com/archives/CCX9DB894/p1751844023449509?thread_ts=1751841330.781889&cid=CCX9DB894