Skip to content

STOR-2974: add OTE extensions for upstream e2e tests - #31455

Open
rvagner78 wants to merge 1 commit into
openshift:mainfrom
rvagner78:azure-disk-ote-registration
Open

STOR-2974: add OTE extensions for upstream e2e tests#31455
rvagner78 wants to merge 1 commit into
openshift:mainfrom
rvagner78:azure-disk-ote-registration

Conversation

@rvagner78

@rvagner78 rvagner78 commented Jul 30, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Tests
    • Added test coverage for the Azure Disk CSI driver extension binary.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot

openshift-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown

@rvagner78: This pull request references STOR-2974 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: afe845a0-bfbe-4010-92e2-c54b582dd869

📥 Commits

Reviewing files that changed from the base of the PR and between 2422d0e and da17e1e.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

The extension test binary registry adds an azure-disk-csi-driver entry mapped to /usr/bin/azure-disk-csi-driver-test.gz.

Changes

Azure Disk CSI Driver Extension

Layer / File(s) Summary
Register Azure Disk CSI driver binary
pkg/test/extensions/binary.go
Adds the azure-disk-csi-driver image tag and its compressed test binary path to extensionBinaries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clearly related to the change, describing added OTE extensions for upstream e2e tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Changed file only adds an extension binary registry entry; no Ginkgo test titles or dynamic names were added.
Test Structure And Quality ✅ Passed Only pkg/test/extensions/binary.go changed to add an extension binary registry entry; no Ginkgo test code or test logic was modified, so these criteria don't apply.
Microshift Test Compatibility ✅ Passed Only a binary registry entry was added; no new Ginkgo tests, APIs, or MicroShift-unsafe resources appear in the diff.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a registry entry was added in pkg/test/extensions/binary.go; no new Ginkgo tests or SNO-sensitive logic were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only adds a test-binary registry entry in pkg/test/extensions/binary.go; no deployment, controller, or scheduling logic changed.
Ote Binary Stdout Contract ✅ Passed Only a registry mapping for azure-disk-csi-driver was added; no main/init/TestMain/setup stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Patch only adds an azure-disk-csi-driver registry entry; no new Ginkgo tests, IPv4 assumptions, or external connectivity were introduced.
No-Weak-Crypto ✅ Passed PR only adds an azure-disk-csi-driver test-binary mapping; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the diff.
Container-Privileges ✅ Passed PR only adds an extension binary registry entry in pkg/test/extensions/binary.go; no container/K8s manifests or privilege fields were changed.
No-Sensitive-Data-In-Logs ✅ Passed Only a static extension-binary registry entry was added; no new logging or sensitive-data handling appears in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rvagner78
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from p0lyn0mial and sjenning July 30, 2026 15:19
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: This PR was included in a payload test run from openshift/azure-disk-csi-driver#154
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: This PR was included in a payload test run from openshift/azure-disk-csi-driver#154
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d66c44c0-8c2e-11f1-8da9-1bd31b2da99f-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi da17e1e link true /test e2e-aws-csi
ci/prow/e2e-gcp-ovn-upgrade da17e1e link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn da17e1e link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn da17e1e link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift-serial da17e1e link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-serial-1of2 da17e1e link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-metal-ipi-ovn-ipv6 da17e1e link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-csi da17e1e link true /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-fips da17e1e link true /test e2e-aws-ovn-fips
ci/prow/e2e-vsphere-ovn-upi da17e1e link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-serial-2of2 da17e1e link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-microshift da17e1e link true /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: This PR was included in a payload test run from openshift/azure-disk-csi-driver#154
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6593e400-8cbb-11f1-99c7-9b2fe0c48d0b-0

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: This PR was included in a payload test run from openshift/azure-disk-csi-driver#154
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8b8e5880-8cbf-11f1-956e-1b4687d7a361-0

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: This PR was included in a payload test run from openshift/azure-disk-csi-driver#154
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fd2dedb0-8cde-11f1-8d3f-b712a6b01f12-0

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: This PR was included in a payload test run from openshift/azure-disk-csi-driver#154
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/53cfd1f0-8cf9-11f1-8b66-506f40aeb130-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants