OCPBUGS-84695: [TNF] Fix update-setup job discovery to limit check to active job - #31451
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Walkthrough
ChangesPacemaker cluster restoration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-ci
Bot
added
the
ready-for-human-review
d919611 to
6c7848d
Compare
|
@jaypoulz: This PR was included in a payload test run from openshift/cluster-etcd-operator#1655
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34b294b0-8b96-11f1-9903-4bbed5998a73-0 |
|
@jaypoulz: This PR was included in a payload test run from openshift/cluster-etcd-operator#1655
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/52a7cd00-8b96-11f1-9573-a9b6be14b37d-0 |
6c7848d to
24d8186
Compare
|
@coderabbitai I'm not addressing the warning because it's not adding new logs, nor is the internal IP of a virtualized node a secret worth protecting. Please mark this as ignored. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh api graphql \
-F owner="openshift" \
-F name="origin" \
-F number=31451 \
-f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
id
isResolved
path
line
comments(first: 20) {
nodes {
author { login }
body
url
}
}
}
}
}
}
}' \
--jq '
.data.repository.pullRequest.reviewThreads.nodes[]
| select(any(.comments.nodes[]?; .author.login == "coderabbitai"))
| {
id,
isResolved,
path,
line,
comments: [
.comments.nodes[]
| select(.author.login == "coderabbitai")
| {author: .author.login, body, url}
]
}'Length of output: 1061 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="openshift/origin"
pr="31451"
pattern='(?i)(\blog(s|ging)?\b|\bip\b|address|secret|sensitive|redact|internal)'
echo "== Inline review comments =="
gh api --paginate "repos/$repo/pulls/$pr/comments?per_page=100" \
--jq ".[] | select((.body // \"\") | test(\"$pattern\")) | {
id, node_id, path, line, author: .user.login, body, html_url
}"
echo "== Pull-request reviews =="
gh api --paginate "repos/$repo/pulls/$pr/reviews?per_page=100" \
--jq ".[] | select((.body // \"\") | test(\"$pattern\")) | {
id, node_id, state, author: .user.login, body, html_url
}"Length of output: 805 🏁 Script executed: #!/bin/bash
set -euo pipefail
gh api --paginate "repos/openshift/origin/issues/31451/comments?per_page=100" \
--jq '
.[]
| select((.user.login // "") | test("coderabbit"; "i"))
| {
id,
node_id,
author: .user.login,
body,
html_url,
created_at
}'Length of output: 13465
I’ve recorded the clarification for future reviews. ✏️ Learnings added
|
jaypoulz
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jaypoulz: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jaypoulz
changed the title
jaypoulz
changed the title
openshift-ci-robot
added
jira/severity-important
|
@jaypoulz: This pull request references Jira Issue OCPBUGS-84695, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: Scheduling tests matching the |
The survivor node's update-setup job performs the actual Pacemaker reconciliation in both old and new CEO architectures: - Old CEO: creates 2 per-node jobs; target exits early, survivor works - New CEO: creates 1 cluster-wide job with round-robin retry (always succeeds on survivor during replacement because Pacemaker runs there) Remove the wait for target-node job since it either doesn't exist (new) or does nothing (old). Only the survivor job matters. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
24d8186 to
6590e15
Compare
|
Bumped the timeout from 3 to 5 minute since it didn't quite make it on the 5.0 verification, but the 4.22 verification passed. |
|
/verified by #31451 (comment) shard 2 |
openshift-ci-robot
added
the
verified
|
@jaypoulz: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jaypoulz: This pull request references Jira Issue OCPBUGS-84695, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fracappa, jaypoulz, vimauro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling required tests: Scheduling tests matching the |
|
/retest-required |
9a3328c
into
openshift:main
|
@jaypoulz: Jira Issue OCPBUGS-84695: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-84695 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jaypoulz: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.22 |
|
@jaypoulz: new pull request created: #31467 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Wait for single update-setup job on survivor node only
The survivor node's update-setup job performs the actual Pacemaker reconciliation in both old and new CEO architectures:
Remove the wait for target-node job since it either doesn't exist (new) or does nothing (old). Only the survivor job matters.
Summary by CodeRabbit
Summary by CodeRabbit