NO-JIRA: Remove Istio configmap workaround from ClusterResourceQuota test

[gcs278]

Summary

Removes the Istio configmap workaround from the ClusterResourceQuota test. The Gateway CA Controller carry patch (PILOT_ENABLE_GATEWAY_API_CA_CERT_ONLY) scopes configmap creation to Gateway namespaces only, so the extra configmaps are no longer created in test namespaces.

The workaround was originally added to account for istio-ca-root-cert being created in every namespace. The configmap name was later renamed to openshift-gw-ca-root-cert via trustBundleName, and with the carry patch, it is only created in namespaces containing Gateway API Gateways.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Updated cluster resource quota testing to fail immediately when creating an additional ConfigMap encounters an error.
  • Removed automatic quota adjustment, status waiting, and retry behavior from the test.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-99920, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Istio 1.30 (OSSM 3.4) replaced the istio-ca-root-cert configmap with istio-ca-crl in every namespace. The ClusterResourceQuota test workaround only checked for istio-ca-root-cert, so it failed to account for the extra configmap and reported a false quota failure.

Changes istio-ca-root-cert → istio-ca-crl and updates the TODO comment from OSSM 3.0.1 to 3.4.1.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gcs278
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

The cluster resource quota test now immediately fails when creating a ConfigMap returns an error, removing the previous Istio ConfigMap check, quota adjustment, status wait, and retry path.

Changes

Cluster quota failure handling

Layer / File(s)	Summary
Immediate ConfigMap creation failure test/extended/quota/clusterquota.go	ConfigMap creation errors now trigger t.Fatalf without checking for an Istio-generated ConfigMap, changing the quota limit, waiting for status, or retrying creation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No dynamic values appear in any Ginkgo title; the PR only edits test body logic, and the existing titles are static strings.
Test Structure And Quality	✅ Passed	The change only removes the Istio retry workaround; the test still has explicit quota wait timeouts and cleanup via AddResourceToDelete/namespace teardown.
Microshift Test Compatibility	✅ Passed	The changed test already has non-MicroShift apigroup tags ([quota,image,monitoring,template]), and the diff adds no new Ginkgo specs or unsupported APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The modified ClusterResourceQuota test uses only namespace and API object quota checks; it has no node, HA, or topology assumptions and needs no SNO skip.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a test workaround was removed; no manifests, operator code, or scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	No process-level stdout writes were added; the file has no main/TestMain/BeforeSuite/init and no fmt.Print/klog stdout usage.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The changed Ginkgo test only manipulates cluster objects; it has no hardcoded IPs, URL construction, or public internet dependencies.
No-Weak-Crypto	✅ Passed	No weak-crypto patterns or secret/token comparisons appear in the touched test file or its package.
Container-Privileges	✅ Passed	PR only edits a Go test file; no container/K8s manifests or privilege settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, etc.) were added.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds no new log output; the modified test only tightens error handling and contains no passwords, tokens, PII, or hostnames in logs.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the removal of the Istio ConfigMap workaround from the ClusterResourceQuota test.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[gcs278]

Hmm, I see a flake related to this last night in hypershift job. Though, maybe the CI stream for hypershift hasn't gotten the Istio 1.30 bump, it's worth waiting to see.

/hold

[openshift-ci-robot]

@gcs278: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Removes the Istio configmap workaround from the ClusterResourceQuota test. The Gateway CA Controller carry patch (PILOT_ENABLE_GATEWAY_API_CA_CERT_ONLY) scopes configmap creation to Gateway namespaces only, so the extra configmaps are no longer created in test namespaces.

The workaround was originally added to account for istio-ca-root-cert being created in every namespace. The configmap name was later renamed to openshift-gw-ca-root-cert via trustBundleName, and with the carry patch, it is only created in namespaces containing Gateway API Gateways.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
• Updated cluster resource quota testing to fail immediately when creating an additional ConfigMap encounters an error.
• Removed automatic quota adjustment, status waiting, and retry behavior from the test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upi	3e7a41d	link	true	/test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.