CORENET-6462: Remove exceptions for network operator#30842
CORENET-6462: Remove exceptions for network operator#30842weliang1 wants to merge 1 commit intoopenshift:mainfrom
Conversation
The network operator should correctly report Available, Progressing, and Degraded state on standard highly-available clusters. Remove the Degraded=True pass-through exception outside upgrade windows and the downstream OCPBUGS-38668 exception, similar to origin#30677 from the storage team. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@weliang1: This pull request references CORENET-6462 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughA conditional block handling the "network" operator's degraded state outside the upgrade window in a test function is removed, eliminating approximately 10 lines of legacy exception logging logic from the upgrade state transition test. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weliang1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@weliang1: This pull request references CORENET-6462 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/retest |
|
@weliang1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
The network operator should correctly report
Available,Progressing, andDegradedstate on standard highly-available clusters.This PR removes two stale exceptions:
Degraded=Truepass-through in the "outside upgrade window" switch (analogous to theauthentication/image-registryspecial handling)OCPBUGS-38668exception that was silencingnetworkDegraded=TruefailuresThis follows the same pattern as #30677 from the storage team.
Jira
https://issues.redhat.com/browse/CORENET-6462
🤖 Generated with Claude Code
Summary by CodeRabbit