Skip to content

CORENET-6462: Remove exceptions for network operator#30842

Open
weliang1 wants to merge 1 commit intoopenshift:mainfrom
weliang1:CORENET-6462-remove-the-exception
Open

CORENET-6462: Remove exceptions for network operator#30842
weliang1 wants to merge 1 commit intoopenshift:mainfrom
weliang1:CORENET-6462-remove-the-exception

Conversation

@weliang1
Copy link
Contributor

@weliang1 weliang1 commented Mar 5, 2026

Summary

The network operator should correctly report Available, Progressing, and Degraded state on standard highly-available clusters.

This PR removes two stale exceptions:

  • The Degraded=True pass-through in the "outside upgrade window" switch (analogous to the authentication/image-registry special handling)
  • The downstream OCPBUGS-38668 exception that was silencing network Degraded=True failures

This follows the same pattern as #30677 from the storage team.

Jira

https://issues.redhat.com/browse/CORENET-6462

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated monitoring test infrastructure for cluster version operator handling, removing specific exception handling logic that was no longer needed.

The network operator should correctly report Available, Progressing,
and Degraded state on standard highly-available clusters. Remove the
Degraded=True pass-through exception outside upgrade windows and the
downstream OCPBUGS-38668 exception, similar to origin#30677 from the
storage team.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@weliang1: This pull request references CORENET-6462 which is a valid jira issue.

Details

In response to this:

Summary

The network operator should correctly report Available, Progressing, and Degraded state on standard highly-available clusters.

This PR removes two stale exceptions:

  • The Degraded=True pass-through in the "outside upgrade window" switch (analogous to the authentication/image-registry special handling)
  • The downstream OCPBUGS-38668 exception that was silencing network Degraded=True failures

This follows the same pattern as #30677 from the storage team.

Jira

https://issues.redhat.com/browse/CORENET-6462

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f8c23616-e933-442b-bd6a-c4da4caa906a

📥 Commits

Reviewing files that changed from the base of the PR and between 0bb7edf and 27c8698.

📒 Files selected for processing (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
💤 Files with no reviewable changes (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

Walkthrough

A conditional block handling the "network" operator's degraded state outside the upgrade window in a test function is removed, eliminating approximately 10 lines of legacy exception logging logic from the upgrade state transition test.

Changes

Cohort / File(s) Summary
Network Operator Test Handling
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
Removes special case handling for network operator degradation checks outside the upgrade window, including associated degraded state logging and control flow branches.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: removing exceptions for the network operator. It matches the PR objectives and the code changes shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed Test file uses stable, deterministic names from static sources (operator names, bugzilla components, enums) with no dynamic values like timestamps, UUIDs, or IP addresses.
Test Structure And Quality ✅ Passed PR removes exception handling for network operator state transitions, improving test effectiveness by eliminating special-case workarounds that masked operator issues. Existing test structure demonstrates reasonable quality with table-driven pattern, appropriate assertions, and consistent patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning March 5, 2026 19:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weliang1
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@weliang1: This pull request references CORENET-6462 which is a valid jira issue.

Details

In response to this:

Summary

The network operator should correctly report Available, Progressing, and Degraded state on standard highly-available clusters.

This PR removes two stale exceptions:

  • The Degraded=True pass-through in the "outside upgrade window" switch (analogous to the authentication/image-registry special handling)
  • The downstream OCPBUGS-38668 exception that was silencing network Degraded=True failures

This follows the same pattern as #30677 from the storage team.

Jira

https://issues.redhat.com/browse/CORENET-6462

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
  • Updated monitoring test infrastructure for cluster version operator handling, removing specific exception handling logic that was no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@weliang1
Copy link
Contributor Author

weliang1 commented Mar 5, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@weliang1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-microshift 27c8698 link true /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants