Add condition for rejecting connection

[Prashanth684]

The "Pods cannot access the /config/master API endpoint" test has been consistently failing on the OKD 5.0 nightly stream. The container images are now based on Centos 10 and that has introduced a new version of curl and the error we see now is "Could not connect to server".

Summary by CodeRabbit

• Tests
  • Improved test robustness by adding support for an additional error message type when internal API connections are unreachable, ensuring tests handle broader connection failure scenarios.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b616bf6f-7b50-4660-b512-2062d660ca86

📥 Commits

Reviewing files that changed from the base of the PR and between 55ebee2 and cf29dc3.

📒 Files selected for processing (1)

• test/extended/csrapprover/csrapprover.go

---

Walkthrough

Tests now accept an additional error string from curl when the internal API is unreachable. "Could not connect to server" is added as an acceptable substring alongside existing error messages "Connection refused" and "Connection timed out".

Changes

Cohort / File(s)	Summary
Test Error Handling test/extended/csrapprover/csrapprover.go	Added "Could not connect to server" as an acceptable error substring in API connectivity tests alongside existing error messages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The PR title 'Add condition for rejecting connection' is vague and does not clearly communicate the main change, which is adding an acceptable error string to a test.	Consider a more specific title that describes what condition is being added and why, such as 'Update CSR approver test to accept additional curl error message' or 'Handle CentOS 10 curl error in CSR approver test'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	Both test names are static and deterministic, containing only descriptive strings with no dynamic information, pod names, timestamps, UUIDs, or identifiers.
Test Structure And Quality	✅ Passed	Test file demonstrates good structure with appropriate Ginkgo setup, meaningful assertions, and the modification reasonably expands error condition handling without compromising test quality.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Prashanth684
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.