Skip to content

Conversation

@hongkailiu
Copy link
Member

We found sometimes in CI that the CVO's waiting is timed out because Kubelet is slow, e.g. 45s, to get a running pod for the target version of the component's deployment.

CVO should not include the time there because it is out of the control of component. However, it is challenging to exclude it in the current CVO's implementation.

The original timeout 2m was there up to CVO's batching strategy (only once in 1m) to update CVO's status for which the component should not be responsible. This pull adjusts it to 3m for the slow Kubelet actions.

The adjustment is only a temporary measure as we do not know how slow it could be for Kubelet such as pulling an image for the deployment. Thus, the ideal solution for the issue here is that CVO figures out how to measure the timing precisely. For now, the compromise is this pull.

We found sometimes in CI that the CVO's waiting is timed out because Kubelet is
slow, e.g. `45s`, to get a running pod for the target version of the component's
deployment.

CVO should not include the time there because it is out of the control of component.
However, it is challenging to exclude it in the current CVO's implementation.

The original timeout `2m` was there up to CVO's batching strategy (only once in `1m`)
to update CVO's status for which the component should not be responsible. This pull
adjusts it to `3m` for the slow Kubelet actions.

The adjustment is only a temporary measure as we do not know how slow it could be
for Kubelet such as pulling an image for the deployment. Thus, the ideal solution
for the issue here is that CVO figures out how to measure the timing precisely.
For now, the compromise is this pull.
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial December 11, 2025 20:45
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2025
@hongkailiu
Copy link
Member Author

/test e2e-aws-ovn-fips

@xueqzhan
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, wking, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2025
@xueqzhan
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 11, 2025
@hongkailiu
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2025

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@opokornyy
Copy link

/cc

@openshift-ci openshift-ci bot requested a review from opokornyy December 16, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants