Migrate must-gather cases to origin #30594
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangwgr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gangwgr
force-pushed
the
migrate-must-gather
branch
from
48038a6 to
3795320
Compare
|
Scheduling required tests: |
|
/retest-required |
gangwgr
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Needs a PR description. |
|
/payload 4.21 nightly blocking |
|
@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4aa84eb0-d64f-11f0-842b-e5b61372c9eb-0 |
gangwgr
force-pushed
the
migrate-must-gather
branch
from
3795320 to
5d45978
Compare
|
/payload 4.21 nightly blocking |
|
@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8efd7b70-d650-11f0-8594-a87de3fee2d0-0 |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 5d45978
New tests seen in this PR at sha: 5d45978
|
gangwgr
force-pushed
the
migrate-must-gather
branch
from
5d45978 to
d0c2dd8
Compare
|
/payload 4.21 nightly blocking |
|
@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d2bcc90-d69b-11f0-8796-7e95dcc6b08d-0 |
|
Scheduling required tests: |
|
/test e2e-aws-ovn-microshift-serial |
|
/retest required |
|
@gangwgr: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/test e2e-aws-ovn-fips |
|
/test e2e-metal-ipi-ovn-ipv6 |
1 similar comment
|
/test e2e-metal-ipi-ovn-ipv6 |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: d0c2dd8
|
gangwgr
force-pushed
the
migrate-must-gather
branch
from
d0c2dd8 to
594e2ba
Compare
|
Scheduling required tests: |
|
@gangwgr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 594e2ba
|
|
Based on my analysis of the CI job configurations and test suite definitions: ❌ NO - The must-gather tests CANNOT be executed in the 4.21 nightly blocking CI jobs you listed. So we don't need to trigger 4.21 nightly blocking ci jobs. Here's why:
Recommendation: If you want the must-gather tests to run in these CI jobs, you need to:
|
these cases run in conformance/parallel suite |
3 participants
This PR migrates 7 must-gather test cases from openshift-tests-private/test/extended/workloads/must_gather.go to origin/test/extended/cli/mustgather.go. These tests validate various must-gather and oc adm
inspect functionality.
Tests Migrated
- Validates must-gather can run in a custom namespace with proper permissions
- Tests gathering OAuth audit logs via must-gather
- Skips on hypershift (External topology - no oauth-server audit logs)
- Tests --node-name flag specifically on hypershift clusters
- Runs ONLY on hypershift (External topology required)
- Validates --since and --since-time filtering for must-gather
- Tests both correct and incorrect time formats
- Skips on hypershift (different must-gather behavior)
- Validates --since and --since-time filtering for oc adm inspect
- Tests both correct and incorrect time formats
- Ensures oc client version is captured in must-gather.logs
- Skips on hypershift (different must-gather behavior)
- Validates gather.logs exist for default and custom must-gather images
- Tests with multiple images (default, CNV, combined)
- Skips on hypershift (different must-gather behavior)
Changes Made
Code Adaptations
Import Additions
Test Metadata
Hypershift Handling
Tests with NonHyperShiftHOST tag now check control plane topology and skip on hypershift:
controlPlaneTopology, err := exutil.GetControlPlaneTopology(oc)
if *controlPlaneTopology == configv1.ExternalTopologyMode {
g.Skip("Hypershift clusters have different must-gather behavior")
}
Test 60213 does the opposite - it requires hypershift and skips on standard clusters.