Skip to content

Conversation

@wangke19
Copy link
Contributor

@wangke19 wangke19 commented Dec 9, 2025

Reapply the changes from PR #29074 that were previously reverted, mark both certificate tests as informing so failures don't block CI jobs, and skip the tests on ROSA clusters.

Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
    • "all tls artifacts must be registered"
    • "all registered tls artifacts must have no metadata violation regressions"

Commit 3: Skip TLS certificate tests on ROSA clusters

  • Added IsRosaCluster() function to test/extended/util/framework.go
  • Skip certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Behavior

After these changes:

On standard OpenShift clusters:

  • Both certificate tests will continue to run in blocking CI jobs
  • Tests use g.Fail() for proper failure reporting
  • Tests have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

On ROSA, MicroShift, and Hypershift clusters:

  • Tests are skipped (these platforms don't auto-collect TLS the same way)

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Avoid running tests on platforms that don't support TLS auto-collection
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from deads2k and sdodson December 9, 2025 08:05
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Add ote.Informing() to both certificate tests so that failures are
recorded but don't block CI jobs:
- all tls artifacts must be registered
- all registered tls artifacts must have no metadata violation regressions

This allows the tests to continue gathering data without blocking
development while certificates are being properly registered and
metadata is being fixed.
@wangke19 wangke19 force-pushed the cert-tests-informing branch from 4a827c1 to a3db6b0 Compare December 9, 2025 08:45
@wangke19 wangke19 changed the title cert tests: mark TLS registry test as informing OCPBUGS-60853: cert tests: mark TLS registry test as informing Dec 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reapply the changes from PR #29074 that were previously reverted, and mark both certificate tests as informing so failures don't block CI jobs.

Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
  • "all tls artifacts must be registered"
  • "all registered tls artifacts must have no metadata violation regressions"

Behavior

After these changes, both certificate tests will:

  • Continue to run in blocking CI jobs
  • Use g.Fail() for proper failure reporting
  • Have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@wangke19
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 11, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: wangke19.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19
Copy link
Contributor Author

/retest

Add IsRosaCluster() function to test/extended/util/framework.go and
use it to skip TLS certificate tests on ROSA clusters, similar to how
we skip for MicroShift and Hypershift.

ROSA clusters do not auto-collect TLS certificates the same way as
standard OpenShift clusters.
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 15, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Reapply the changes from PR #29074 that were previously reverted, mark both certificate tests as informing so failures don't block CI jobs, and skip the tests on ROSA clusters.

Changes

Commit 1: Reapply PR #29074 (was reverted in #30358)

Commit 2: Mark TLS certificate tests as informing

  • Added import for github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo
  • Added ote.Informing() to both certificate tests:
  • "all tls artifacts must be registered"
  • "all registered tls artifacts must have no metadata violation regressions"

Commit 3: Skip TLS certificate tests on ROSA clusters

  • Added IsRosaCluster() function to test/extended/util/framework.go
  • Skip certificate tests on ROSA clusters (similar to MicroShift and Hypershift)
  • ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters

Behavior

After these changes:

On standard OpenShift clusters:

  • Both certificate tests will continue to run in blocking CI jobs
  • Tests use g.Fail() for proper failure reporting
  • Tests have ote.Informing() label → Non-blocking (failures won't fail CI)
  • Gather data about TLS artifacts and metadata violations without blocking PRs

On ROSA, MicroShift, and Hypershift clusters:

  • Tests are skipped (these platforms don't auto-collect TLS the same way)

Benefits

  • Tests provide proper failure reports with g.Fail()
  • Tests are marked as informing, so failures are recorded but don't block development
  • We can gather data and stabilize the tests while work continues on certificate registration and metadata compliance
  • Avoid running tests on platforms that don't support TLS auto-collection
  • Once tests are stable, the ote.Informing() label can be removed to make them blocking again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangke19
Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@wangke19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 f7b77f2 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wangke19
Copy link
Contributor Author

/assign @sanchezl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants