-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPBUGS-60853: cert tests: mark TLS registry test as informing #30585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Scheduling required tests: |
This reverts commit 714b0f2.
Add ote.Informing() to both certificate tests so that failures are recorded but don't block CI jobs: - all tls artifacts must be registered - all registered tls artifacts must have no metadata violation regressions This allows the tests to continue gathering data without blocking development while certificates are being properly registered and metadata is being fixed.
4a827c1 to
a3db6b0
Compare
|
@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/jira refresh |
|
@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: wangke19. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
Add IsRosaCluster() function to test/extended/util/framework.go and use it to skip TLS certificate tests on ROSA clusters, similar to how we skip for MicroShift and Hypershift. ROSA clusters do not auto-collect TLS certificates the same way as standard OpenShift clusters.
|
@wangke19: This pull request references Jira Issue OCPBUGS-60853, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wangke19 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
@wangke19: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @sanchezl |
Reapply the changes from PR #29074 that were previously reverted, mark both certificate tests as informing so failures don't block CI jobs, and skip the tests on ROSA clusters.
Changes
Commit 1: Reapply PR #29074 (was reverted in #30358)
testresult.Flakef()tog.Fail()for certificate testsCommit 2: Mark TLS certificate tests as informing
github.com/openshift-eng/openshift-tests-extension/pkg/ginkgoote.Informing()to both certificate tests:Commit 3: Skip TLS certificate tests on ROSA clusters
IsRosaCluster()function totest/extended/util/framework.goBehavior
After these changes:
On standard OpenShift clusters:
g.Fail()for proper failure reportingote.Informing()label → Non-blocking (failures won't fail CI)On ROSA, MicroShift, and Hypershift clusters:
Benefits
g.Fail()ote.Informing()label can be removed to make them blocking again