OCPBUGS-65970: Fix MachineConfigNode test in two-node fencing clusters

[isabella-janssen]

What I did:
This updates the Should properly transition through MCN conditions on rebootless node update test to apply a MC against the master MCP for any cluster where no worker MCP machines exist. Previously, only SNO clusters were treated differently, leading to issues with the test when the two-node fencing tests were turned on.

How to verify:

• The best way to make sure this did not break anything is to make sure all the suites running this test are still passing as intended.
• To make sure the two-node case is passing with this change, we need to look at a rehearsal of the two-node fencing suite in [release-4.20] OCPBUGS-66963: Fix MachineConfigNode test in two-node fencing clusters #30540, since this reboot test does not run in tech preview in 4.21 (with the previous introduction of MCO-1870: Skip MCN condition transition test in clusters with ImageModeStatusReporting FeatureGate is enabled #30505).

[openshift-ci-robot]

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-65970, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[isabella-janssen]

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-two-node-fencing-serial

[openshift-ci]

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-two-node-fencing-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f52e2a20-ca16-11f0-9a59-0f175180fd13-0

[isabella-janssen]

/jira refresh

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-65970, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-65970, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

What I did:
This updates the Should properly transition through MCN conditions on rebootless node update test to apply a MC against the master MCP for any cluster where no worker MCP machines exist. Previously, only SNO clusters were treated differently, leading to issues with the test when the two-node fencing tests were turned on.

How to verify:

• The best way to make sure this did not break anything is to make sure all the suites running this test are still passing as intended.
• To make sure the two-node case is passing with this change, we need to look at a rehersal of the two-node fencing suite in [release-4.20] OCPBUGS-66963: Fix MachineConfigNode test in two-node fencing clusters #30540, since this reboot test does not run in tech preview in 4.21 (with the previous introduction of MCO-1870: Skip MCN condition transition test in clusters with ImageModeStatusReporting FeatureGate is enabled #30505).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ovn-two-node-fencing-serial periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3

[openshift-ci]

@isabella-janssen: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ovn-two-node-fencing-serial
• periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
• periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
• periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
• periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
• periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5bab7270-d0c6-11f0-8c44-8223dd6a90bd-0

[isabella-janssen]

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3

[openshift-ci]

@isabella-janssen: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
• periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
• periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
• periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
• periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d449c1e0-d1fd-11f0-964f-b102bcd0f462-0

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[isabella-janssen]

/verified by @isabella-janssen

The test fix has been verified by the rehearsal run of the two-node fencing job here and by the required payload rehearsal here.

[openshift-ci-robot]

@isabella-janssen: This PR has been marked as verified by @isabella-janssen.

Details

In response to this:

/verified by @isabella-janssen

The test fix has been verified by the rehearsal run of the two-node fencing job here and by the required payload rehearsal here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-65970, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What I did:
This updates the Should properly transition through MCN conditions on rebootless node update test to apply a MC against the master MCP for any cluster where no worker MCP machines exist. Previously, only SNO clusters were treated differently, leading to issues with the test when the two-node fencing tests were turned on.

How to verify:

• The best way to make sure this did not break anything is to make sure all the suites running this test are still passing as intended.
• To make sure the two-node case is passing with this change, we need to look at a rehearsal of the two-node fencing suite in [release-4.20] OCPBUGS-66963: Fix MachineConfigNode test in two-node fencing clusters #30540, since this reboot test does not run in tech preview in 4.21 (with the previous introduction of MCO-1870: Skip MCN condition transition test in clusters with ImageModeStatusReporting FeatureGate is enabled #30505).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/retest-required

[umohnani8]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/machine_config/OWNERS [isabella-janssen,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isabella-janssen]

/label acknowledge-critical-fixes-only

This fix needs to be backported to 4.20 to fix persistent failures of the Should properly transition through MCN conditions on rebootless node update test in the periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ovn-two-node-fencing-serial job. With no clear timeline on branching and passing rehearsal required payloads this change impacts, this change should be safe to merge now and is important to improving the 4.20 test health.

[openshift-ci]

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@isabella-janssen: Jira Issue Verification Checks: Jira Issue OCPBUGS-65970
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65970 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

What I did:
This updates the Should properly transition through MCN conditions on rebootless node update test to apply a MC against the master MCP for any cluster where no worker MCP machines exist. Previously, only SNO clusters were treated differently, leading to issues with the test when the two-node fencing tests were turned on.

How to verify:

• The best way to make sure this did not break anything is to make sure all the suites running this test are still passing as intended.
• To make sure the two-node case is passing with this change, we need to look at a rehearsal of the two-node fencing suite in [release-4.20] OCPBUGS-66963: Fix MachineConfigNode test in two-node fencing clusters #30540, since this reboot test does not run in tech preview in 4.21 (with the previous introduction of MCO-1870: Skip MCN condition transition test in clusters with ImageModeStatusReporting FeatureGate is enabled #30505).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.21.0-0.nightly-2025-12-09-062745