Skip to content

Conversation

wangke19
Copy link
Contributor

@wangke19 wangke19 commented Oct 20, 2025

This PR cherry-picks the following commits from ocpbugs-35855-tests branch to release-4.19:

  • 937c238: add more images dryrun tests
  • 5dc8051: fix: gofmt and JSON validation issues
  • 55637ed: Update zz_generated.annotations.go for test

Changes

  • Enhanced images dryrun test functionality with additional test cases
  • Fixed gofmt import ordering in test/extended/images/dryrun.go
  • Note: JSON validation fix for index.json was skipped as the file was deleted in target branch

Testing

  • Verify dryrun tests pass
  • Check gofmt formatting is correct

Related to: OCPBUGS-35855

- Fix gofmt import ordering in test/extended/images/dryrun.go
- Fix invalid JSON format in test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangke19
Once this PR has been reviewed and has the lgtm label, please assign flavianmissi, pedjak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangke19
Copy link
Contributor Author

/jira cherry-pick OCPBUGS-35855

@openshift-ci-robot
Copy link

@wangke19: Detected clone of Jira Issue OCPBUGS-35855 with correct target version. Will retitle the PR to link to the clone.
/retitle OCPBUGS-57206: Cherry-pick OCPBUGS-35855 tests to release-4.19

In response to this:

/jira cherry-pick OCPBUGS-35855

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Cherry-pick OCPBUGS-35855 tests to release-4.19 OCPBUGS-57206: Cherry-pick OCPBUGS-35855 tests to release-4.19 Oct 20, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 20, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-57206, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR cherry-picks the following commits from ocpbugs-35855-tests branch to release-4.19:

  • 937c238: add more images dryrun tests
  • 5dc8051: fix: gofmt and JSON validation issues
  • 55637ed: Update zz_generated.annotations.go for test

Changes

  • Enhanced images dryrun test functionality with additional test cases
  • Fixed gofmt import ordering in test/extended/images/dryrun.go
  • Note: JSON validation fix for index.json was skipped as the file was deleted in target branch

Testing

  • Verify dryrun tests pass
  • Check gofmt formatting is correct

Related to: OCPBUGS-35855

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19 wangke19 changed the title OCPBUGS-57206: Cherry-pick OCPBUGS-35855 tests to release-4.19 [Release-4.19]OCPBUGS-57206: Add imagestream update dryrun test Oct 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

@wangke19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade 55637ed link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 55637ed link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-microshift-serial 55637ed link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-image-registry 55637ed link true /test e2e-aws-ovn-image-registry
ci/prow/okd-scos-e2e-aws-ovn 55637ed link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-edge-zones 55637ed link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-microshift 55637ed link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-fips 55637ed link true /test e2e-aws-ovn-fips
ci/prow/images 55637ed link true /test images
ci/prow/e2e-aws-ovn-serial-1of2 55637ed link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-serial-2of2 55637ed link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-ovn 55637ed link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn-upi 55637ed link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn 55637ed link true /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants