Skip to content

CNV-64163: Fixed namespace value in localnet UDN doc #95180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 24, 2025

@sjhala-ccs: This pull request references CNV-64163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-64163

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 24, 2025

@sjhala-ccs: This pull request references CNV-64163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-64163

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2025
@sjhala-ccs sjhala-ccs added this to the Continuous Release milestone Jun 24, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 24, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 24, 2025

@sjhala-ccs: This pull request references CNV-64163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-64163

Link to docs preview: https://95180--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-secondary-udn.html#virt-creating-secondary-udn-namespace_virt-connecting-vm-to-secondary-udn

https://95180--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-secondary-udn.html#virt-attaching-vm-to-secondary-udn_virt-connecting-vm-to-secondary-udn

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the examples usable, thanks for that.

@ormergi one request for your opinion: I see the C-UDN being configured has physicalNetworkName: tenantblue as its value. This C-UDN interconnects the "blue" and "red" namespaces. Would it make sense to incorporate that depth into the physical network name ? i.e. calling it purple (red + blue) or something like that ? I do understand it does not matter - what matters is that the physical network name matches the NNCP bridge mappings provided.

Just some food for thought @sjhala-ccs .

@ormergi
Copy link

ormergi commented Jun 25, 2025

This makes the examples usable, thanks for that.

@ormergi one request for your opinion: I see the C-UDN being configured has physicalNetworkName: tenantblue as its value. This C-UDN interconnects the "blue" and "red" namespaces. Would it make sense to incorporate that depth into the physical network name ? i.e. calling it purple (red + blue) or something like that ? I do understand it does not matter - what matters is that the physical network name matches the NNCP bridge mappings provided.

Just some food for thought @sjhala-ccs .

Yep, make sense to rename the physicalNetworkName to something common (e.g.: purple ) or non exclusively related to one of the namespaces (localnet1)

@sjhala-ccs sjhala-ccs requested review from maiqueb and Anatw June 26, 2025 13:57
@sjhala-ccs sjhala-ccs added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 26, 2025
Copy link

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

Copy link

@ormergi ormergi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneczypor
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 26, 2025
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 26, 2025
Copy link

@Anatw Anatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! An additional small change is needed.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2025
Copy link

@Anatw Anatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2025

@sjhala-ccs: This pull request references CNV-64163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-64163

Link to docs preview: https://95180--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-secondary-udn.html#virt-creating-secondary-udn-namespace_virt-connecting-vm-to-secondary-udn

https://95180--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-secondary-udn.html#virt-attaching-vm-to-secondary-udn_virt-connecting-vm-to-secondary-udn

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jul 10, 2025

@sjhala-ccs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sjhala-ccs sjhala-ccs merged commit 4065c51 into openshift:main Jul 10, 2025
2 checks passed
@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.19

@sjhala-ccs
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #95934

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #95935

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 branch/enterprise-4.20 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants