Skip to content

RHDEVDOCS 6414 new Results CLI #95134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: pipelines-docs-main
Choose a base branch
from
Open

RHDEVDOCS 6414 new Results CLI #95134

wants to merge 11 commits into from

Conversation

mramendi
Copy link
Contributor

@mramendi mramendi commented Jun 24, 2025 •
edited
Loading

Version(s):

please cp to pipelines-docs-1.19
Issue:

RHDEVDOCS 6414

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2025
@mramendi mramendi changed the title RHDEVDOCS 6144 new Results CLI RHDEVDOCS 6414 new Results CLI Jun 24, 2025
@mramendi
Copy link
Contributor Author

https://issues.redhat.com/browse/RHDEVDOCS-6414

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 24, 2025 •
edited
Loading

🤖 Tue Jun 24 15:11:30 - Prow CI generated the docs preview:

https://95134--ocpdocs-pr.netlify.app/openshift-pipelines/latest/records/using-tekton-results-for-openshift-pipelines-observability.html

divyansh42
divyansh42 reviewed Jun 24, 2025
View reviewed changes
Copy link

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mramendi I have added a few comments which are mostly related to the changes in the functionality and also a few wrong flags getting used.
There were a few minor things as well, I have added those in the code suggestions. Please take a look and let me know if any of the comments need further clarification

divyansh42
divyansh42 suggested changes Jun 24, 2025
View reviewed changes
Copy link

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the required changes.
I have added a few more minor nitpicks, Could you please take a look?

Also, I was thinking if we can also mention that if the user doesn't provide -n flag then the current namespace will be used. Although it is obvious for any k8s CLI, but if we just want to mention to be more clear.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 24, 2025

@mramendi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

divyansh42
divyansh42 approved these changes Jun 24, 2025
View reviewed changes
Copy link

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyansh42 divyansh42 divyansh42 approved these changes

Assignees

@divyansh42 divyansh42

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mramendi @ocpdocs-previewbot @divyansh42