-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-57952 changed agentSocketPath to agentSocketName #95106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Mon Jun 23 14:44:34 - Prow CI generated the docs preview: |
@wgabor0427: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that on "enterprise-4.18", we need also to fix the indentation:
openshift-docs/modules/zero-trust-manager-oidc-config.adoc
Lines 32 to 34 in e2604f4
trustDomain: <trust_domain> #<1> | |
agentSocketPath: 'spire-agent.sock' #<2> | |
jwtIssuer: <jwt_issuer_domain> #<3> |
should be:
trustDomain: <trust_domain> #<1>
agentSocketName: 'spire-agent.sock' #<2>
jwtIssuer: <jwt_issuer_domain> #<3>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label peer-review-needed |
/lgtm |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick enterprise-4.20 |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.18 |
@ShaunaDiaz: new pull request created: #95176 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #95177 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: #95106 failed to apply on top of branch "enterprise-4.18":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@wgabor0427 Looks like this one will need a manual cherry-pick. You can put it back in queue when you have it ready. |
/cherrypick enterprise-4.18 |
@wgabor0427: #95106 failed to apply on top of branch "enterprise-4.18":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.18+
Issue:
https://issues.redhat.com/browse/OCPBUGS-57952
Link to docs preview:
https://95106--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/zero_trust_workload_identity_manager/zero-trust-manager-configuration.html
QE review:
Additional information: