Skip to content

OCPBUGS-57952 changed agentSocketPath to agentSocketName #95106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

wgabor0427
Copy link
Contributor

@wgabor0427 wgabor0427 commented Jun 23, 2025

Sorry, something went wrong.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2025
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Jun 23, 2025

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lunarwhite
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that on "enterprise-4.18", we need also to fix the indentation:

trustDomain: <trust_domain> #<1>
agentSocketPath: 'spire-agent.sock' #<2>
jwtIssuer: <jwt_issuer_domain> #<3>

should be:

  trustDomain: <trust_domain> #<1>
  agentSocketName: 'spire-agent.sock' #<2>
  jwtIssuer: <jwt_issuer_domain> #<3>

Copy link

@anirudhAgniRedhat anirudhAgniRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wgabor0427
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 24, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 24, 2025
@mburke5678
Copy link
Contributor

/lgtm

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 24, 2025
@wgabor0427
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 24, 2025
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 24, 2025
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jun 24, 2025
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz ShaunaDiaz merged commit a826906 into openshift:main Jun 24, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.20

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.19

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #95176

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #95177

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: #95106 failed to apply on top of branch "enterprise-4.18":

Applying: OCPBUGS-57952 changed agentSocketPath to agentSocketName
Using index info to reconstruct a base tree...
M	modules/zero-trust-manager-oidc-config.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/zero-trust-manager-oidc-config.adoc
CONFLICT (content): Merge conflict in modules/zero-trust-manager-oidc-config.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-57952 changed agentSocketPath to agentSocketName

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz: #95106 failed to apply on top of branch "enterprise-4.18":

Applying: OCPBUGS-57952 changed agentSocketPath to agentSocketName
Using index info to reconstruct a base tree...
M	modules/zero-trust-manager-oidc-config.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/zero-trust-manager-oidc-config.adoc
CONFLICT (content): Merge conflict in modules/zero-trust-manager-oidc-config.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-57952 changed agentSocketPath to agentSocketName

@wgabor0427 Looks like this one will need a manual cherry-pick. You can put it back in queue when you have it ready.

@wgabor0427
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@wgabor0427: #95106 failed to apply on top of branch "enterprise-4.18":

Applying: OCPBUGS-57952 changed agentSocketPath to agentSocketName
Using index info to reconstruct a base tree...
M	modules/zero-trust-manager-oidc-config.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/zero-trust-manager-oidc-config.adoc
CONFLICT (content): Merge conflict in modules/zero-trust-manager-oidc-config.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-57952 changed agentSocketPath to agentSocketName

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants