Skip to content

HCIDOCS-75: Add IPI installation workflow information to our document… #94545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HCIDOCS-75: Add IPI installation workflow information to our document… #94545

wants to merge 1 commit into from
+54 −0

Conversation

kdrake20
Copy link
Contributor

@kdrake20 kdrake20 commented Jun 10, 2025 •
edited
Loading

Fixes: HCIDOCS-75

For: OCP 4.15+

Preview

Approvals - /lgtm:

  • SME
  • QE
  • Peer Review

Sorry, something went wrong.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025 •
edited by openshift-ci bot
Loading

@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-75

For: OCP 4.15+

Preview

Approvals - /lgtm:

  • SME
  • QE
  • Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 10, 2025 •
edited
Loading

🤖 Thu Jul 17 18:33:38 - Prow CI generated the docs preview:

https://94545--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-prerequisites.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 10, 2025
View reviewed changes
@kdrake20 kdrake20 force-pushed the HCIDOCS-75 branch 4 times, most recently from c0ec060 to 48b8043 Compare June 12, 2025 19:58
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2025 •
edited by openshift-ci bot
Loading

@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-75

For: OCP 4.15+

Preview

Approvals - /lgtm:

  • SME
  • QE
  • Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

dtantsur
dtantsur reviewed Jun 18, 2025
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, some comments inline.

@kdrake20 kdrake20 force-pushed the HCIDOCS-75 branch 2 times, most recently from 9ea3827 to 7f4f67d Compare June 18, 2025 16:56
@honza
Copy link
Member

honza commented Jun 18, 2025

/lgtm

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels Jul 11, 2025
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 14, 2025
skopacz1
skopacz1 reviewed Jul 14, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, otherwise LGTM!

Just an FYI though, I did find it a little hard to review this because of several instances where Michael made a good suggestion, and you replied that you updated with the suggestion, but it didn't seem like you pushed that change to this PR. So it made it hard for me to decide what to comment on and what to leave alone. No big deal though!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 14, 2025
@kdrake20 kdrake20 force-pushed the HCIDOCS-75 branch 2 times, most recently from b61658f to b2678a9 Compare July 14, 2025 15:32
@kdrake20
Copy link
Contributor Author

/remove-label peer-review-done
/label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels Jul 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 14, 2025 •
edited by openshift-ci bot
Loading

@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-75

For: OCP 4.15+

Preview

Approvals - /lgtm:

  • SME
  • QE
  • Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

sgoveas
sgoveas approved these changes Jul 15, 2025
View reviewed changes
Copy link

@sgoveas sgoveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2025 •
edited by openshift-ci bot
Loading

@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-75

For: OCP 4.15+

Preview

Approvals - /lgtm:

  • SME
  • QE
  • Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 16, 2025
@lpettyjo lpettyjo self-requested a review July 16, 2025 11:04
lpettyjo
lpettyjo reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025 •
edited by openshift-ci bot
Loading

@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-75

For: OCP 4.15+

Preview

Approvals - /lgtm:

  • SME
  • QE
  • Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 17, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025 •
edited by openshift-ci bot
Loading

@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-75

For: OCP 4.15+

Preview

Approvals - /lgtm:

  • SME
  • QE
  • Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sorry, something went wrong.

@kdrake20
HCIDOCS-75: Add IPI installation workflow information to our document…
Loading
Loading status checks…
ac777d5 
…ation
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 17, 2025

@kdrake20: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur

@johnwilkins johnwilkins

@mburke5678 mburke5678

@lpettyjo lpettyjo

@bscott-rh bscott-rh

@skopacz1 skopacz1

@ocpdocs-vale-bot ocpdocs-vale-bot

@sgoveas sgoveas

Assignees

@honza honza

@sgoveas sgoveas

Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet