Skip to content

OSDOCS:14467 [GA] Pin and preload images #92741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS:14467 [GA] Pin and preload images #92741

wants to merge 1 commit into from

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Apr 29, 2025 •
edited
Loading

Currently (5/7) planned for a 4.19.z release

https://issues.redhat.com/browse/OSDOCS-14467
https://issues.redhat.com/browse/MCO-1258

QE review:

  • QE has approved this change.

PEER REVIEW REQUEST 5/30. Please review the changes in this commit, where I changed the name and other details. The technical details have been peer-reviewed.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 29, 2025 •
edited
Loading

🤖 Mon Jun 02 16:37:46 - Prow CI generated the docs preview:

https://92741--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/machine-config-pin-preload-images-about.html

@mburke5678
Copy link
Contributor Author

mburke5678 commented May 5, 2025 •
edited
Loading

@RishabhSaini @ptalgulk01 Can you PTAL?

ptalgulk01
ptalgulk01 reviewed May 6, 2025
View reviewed changes
@RishabhSaini
Copy link

LGTM

@mburke5678 mburke5678 added this to the Continuous Release milestone May 7, 2025
isabella-janssen
isabella-janssen reviewed May 8, 2025
View reviewed changes
@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label May 21, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 21, 2025
lahinson
lahinson reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few questions and comments -- in particular, about whether to write "preload and pin" or "pin and preload".

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 21, 2025
@mburke5678 mburke5678 added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels May 30, 2025
mletalie
mletalie reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 30, 2025
mletalie
mletalie reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done
/lgtm

machine_configuration/machine-config-pin-preload-images-about.adoc Outdated

Pre-loading and pinning images also ensures that the images are available when deploying applications, so that you can deploy in a predictable time. Another benefit to pre-loading and pinning images is that image garbage collection does not remove the pinned images.
Pinned images also ensures that the images are available when deploying applications, so that you can deploy in a predictable time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: When you say "predictable time", does this mean that this feature will give an accurate time for deployment, or it speeds up the deployment time...maybe both?

machine_configuration/machine-config-pin-preload-images-about.adoc Outdated

You can pre-load and pin images by using a a `PinnedImageSet` custom resource (CR), as described in _Pre-loading and pinning images_. Pinned images are stored on the nodes in the `/etc/crio/crio.conf.d/50-pinned-images` file. The contents of the file appear similar to the following example:
You can pin images to specific nodes by using a `PinnedImageSet` custom resource (CR), as described in _Pinning images_. Pinned images are stored on the nodes in the `/etc/crio/crio.conf.d/50-pinned-images` file on those. The contents of the file appear similar to the following example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there is info missing in the second sentence? Unclear about what "..on those" means.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 30, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2025
@mletalie
Copy link
Contributor

mletalie commented May 30, 2025 •
edited
Loading

@mburke5678 , Great job on this doc. Just had a couple of comments...and please remember to squash commits. Thanks!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 2, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 2, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson lahinson left review comments

@mletalie mletalie mletalie left review comments

@ptalgulk01 ptalgulk01 ptalgulk01 left review comments

@isabella-janssen isabella-janssen isabella-janssen left review comments

Assignees

@mletalie mletalie

Labels
branch/enterprise-4.19 branch/enterprise-4.20 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@mburke5678 @ocpdocs-previewbot @RishabhSaini @mletalie @bergerhoffer @openshift-merge-robot @lahinson @ptalgulk01 @isabella-janssen