OSDOCS-4872: change variant rhcos to openshift

[jldohmann]

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-4872

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-4872/installing/installing_sno/install-sno-installing-sno.html#create-custom-live-rhcos-iso_install-sno-installing-sno-with-the-assisted-installer

QE review:

• QE has approved this change.

Additional information:

[openshift-ci-robot]

@jldohmann: This pull request references OSDOCS-4872 which is a valid jira issue.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-4872

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-4872/installing/installing_sno/install-sno-installing-sno.html#create-custom-live-rhcos-iso_install-sno-installing-sno-with-the-assisted-installer

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ocpdocs-previewbot]

🤖 Updated build preview is available at:
https://58302--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14173

[jldohmann]

@mike-nguyen could you PTAL for QE ack? this updates the SNO docs to reflect the changes in Butane support. it doesn't look like these docs existed pre-4.12, so i've marked them as 4.12+

[mike-nguyen]

I'm not too familiar with single node mode so I can't comment on the dropping of root ssh login. If SNO is more like OCP now with only allowing core user login then the changes LGTM. Do you know if SNO has QE that can look over these changes?

[maxwelldb]

Looking pretty good. One question for you, as well as two suggested changes for while you're working on the file.

[jldohmann]

4621c33..aeb7429 implement peer review feedback
aeb7429..290499c rebase
290499c..04bdd8b implement QE feedback pt.1
04bdd8b..dd15d62 implement QE feedback pt.2
dd15d62..003269e reverse {product-version} in link macro back to 4.12

[jldohmann]

@yunjiang29 could you PTAL for QE ack, or do you know who could take a look for QE ack? this PR updates the SNO docs to reflect the changes in Butane support. thank you!

[sgoveas]

/lgtm

[openshift-ci-robot]

@jldohmann: This pull request references OSDOCS-4872 which is a valid jira issue.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OSDOCS-4872

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-4872/installing/installing_sno/install-sno-installing-sno.html#create-custom-live-rhcos-iso_install-sno-installing-sno-with-the-assisted-installer

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jldohmann]

I am leaving the hardcoded 4.12 version in the link macro but will apply cherrypicks with a CIT to return back and fix for 4.13. The issue with using {product-version} in its place is detailed here

[jldohmann]

/cherrypick enterprise-4.13

[jldohmann]

/cherrypick enterprise-4.12

[openshift-cherrypick-robot]

@jldohmann: new pull request created: #58847

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jldohmann: #58302 failed to apply on top of branch "enterprise-4.12":

Applying: OSDOCS-4872: change variant rhcos to openshift
Using index info to reconstruct a base tree...
M	modules/creating-custom-live-rhcos-iso.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/creating-custom-live-rhcos-iso.adoc
CONFLICT (content): Merge conflict in modules/creating-custom-live-rhcos-iso.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-4872: change variant rhcos to openshift
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.