Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: adm release: simplify manifest iteration #1917

Merged
merged 1 commit into from
Nov 28, 2024
Merged

NO-JIRA: adm release: simplify manifest iteration #1917

merged 1 commit into from
Nov 28, 2024

Conversation

petr-muller
Copy link
Member

Full imageData was passed to the callback but existing callbacks only needed the containing directory. Therefore the callback signature can be simplified to func(directory, content, operator)

/cc @wking @DavidHurta

@petr-muller
adm release: simplify manifest iteration
a6c341f 
Full `imageData` was passed to the callback but existing callbacks only needed the containing directory. Therefore the callback signature can be simplified to `func(directory, content, operator)`
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2024
@openshift-ci-robot
Copy link

@petr-muller: This pull request explicitly references no jira issue.

In response to this:

Full imageData was passed to the callback but existing callbacks only needed the containing directory. Therefore the callback signature can be simplified to func(directory, content, operator)

/cc @wking @DavidHurta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from DavidHurta and wking November 19, 2024 13:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@petr-muller
Copy link
Member Author

/retest

Neither failure looks relevant

@petr-muller
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Member Author

/retest

@petr-muller
Copy link
Member Author

/label acknowledge-critical-fixes-only

We're now post-branching so applying this label should be fine

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 25, 2024
@petr-muller
Copy link
Member Author

/test e2e-aws-ovn-serial

The timeout-on-deprovision failures are really annoying:

 INFO[2024-11-25T17:28:27Z] Running step e2e-aws-ovn-serial-ipi-deprovision-deprovision. 
{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2024-11-25T17:34:12Z"}

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e56829 and 2 for PR HEAD a6c341f in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e56829 and 2 for PR HEAD a6c341f in total

@petr-muller
Copy link
Member Author

/retest

@petr-muller
Copy link
Member Author

petr-muller commented Nov 25, 2024 •
edited
Loading

b06 issues :(

 Trying to pull registry.build06.ci.openshift.org/ci/managed-clonerefs@sha256:8045e4633e3e825a92fa4fbe58ad6e7cc73bd45e5c0f207a0cc0c3666b49949f...
error: error creating buildah builder: initializing source docker://registry.build06.ci.openshift.org/ci/managed-clonerefs@sha256:8045e4633e3e825a92fa4fbe58ad6e7cc73bd45e5c0f207a0cc0c3666b49949f: pinging container registry registry.build06.ci.openshift.org: Get "https://registry.build06.ci.openshift.org/v2/": dial tcp: lookup registry.build06.ci.openshift.org on 172.30.0.10:53: no such host

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e56829 and 2 for PR HEAD a6c341f in total

@petr-muller
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e56829 and 2 for PR HEAD a6c341f in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e56829 and 2 for PR HEAD a6c341f in total

@petr-muller
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e56829 and 2 for PR HEAD a6c341f in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e56829 and 2 for PR HEAD a6c341f in total

@petr-muller
Copy link
Member Author

We're bumping the timeout for the serial job in openshift/release#59281 because its pass rate dropped significantly recently.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d06d08 and 1 for PR HEAD a6c341f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d06d08 and 2 for PR HEAD a6c341f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d06d08 and 2 for PR HEAD a6c341f in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d06d08 and 2 for PR HEAD a6c341f in total

@petr-muller
Copy link
Member Author

/test e2e-aws-ovn-upgrade

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d06d08 and 2 for PR HEAD a6c341f in total

@petr-muller
Copy link
Member Author

I think we are hitting TRT-1900 now

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d06d08 and 2 for PR HEAD a6c341f in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d06d08 and 2 for PR HEAD a6c341f in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 13cd2ce into openshift:master Nov 28, 2024
14 checks passed
@petr-muller petr-muller deleted the process-cvo-manifests-refactor-2 branch November 29, 2024 01:00
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli
This PR has been included in build openshift-enterprise-cli-container-v4.19.0-202411290038.p0.g13cd2ce.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-tools
This PR has been included in build ose-tools-container-v4.19.0-202411290038.p0.g13cd2ce.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer
This PR has been included in build openshift-enterprise-deployer-container-v4.19.0-202411290038.p0.g13cd2ce.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts
This PR has been included in build ose-cli-artifacts-container-v4.19.0-202411290038.p0.g13cd2ce.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHurta DavidHurta DavidHurta approved these changes

@wking wking Awaiting requested review from wking

Assignees

@DavidHurta DavidHurta

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petr-muller @openshift-ci-robot @openshift-bot @DavidHurta