[OADP-8700] Guard NodeAgent.ExtraArgs access against nil when using restic config

[PrasadJoshi12]

Why the changes were made

Fixes: OADP-8700

How to test the changes made

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d6ed481-c612-4b0b-a7ba-e8bf00ca6299

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.37%. Comparing base (9744818) to head (64f53b9).

⚠️ Current head 64f53b9 differs from pull request most recent head 346de1f

Please upload reports for the commit 346de1f to get more accurate results.

Additional details and impacted files

@@            Coverage Diff            @@
##           oadp-1.4    #2394   +/-   ##
=========================================
  Coverage     39.37%   39.37%           
=========================================
  Files            30       30           
  Lines          5211     5211           
=========================================
  Hits           2052     2052           
  Misses         2959     2959           
  Partials        200      200           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[PrasadJoshi12]

/retest

[PrasadJoshi12]

Verified in cluster

$ oc logs openshift-adp-controller-manager-5c6798467-tb6sc
I0819 09:40:23.266858       1 leaderelection.go:91] The leader election gives 4 retries and allows for 30s of clock skew. The kube-apiserver downtime tolerance is 78s. Worst non-graceful lease acquisition is 2m43s. Worst graceful lease acquisition is {26s}.
I0819 09:40:23.277820       1 leaderelection.go:35] infrastructure object status: &{windows-prajoshi-26s7q AWS 0x128a2b6f9380  https://api.windows-prajoshi.mg.dog8code.com:6443 https://api-int.windows-prajoshi.mg.dog8code.com:6443 HighlyAvailable HighlyAvailable None}
2026-08-19T09:40:23Z	INFO	setup	patching operator namespace with Pod security admission (PSA) labels to privileged
2026-08-19T09:40:23Z	INFO	setup	Waiting for required OpenShift CRDs to be available	{"crds": [{},{}], "timeout": "10m0s"}
2026-08-19T09:40:23Z	INFO	setup	All required CRDs are available, proceeding with controller startup
2026-08-19T09:40:23Z	INFO	setup	starting manager
2026-08-19T09:40:23Z	INFO	controller-runtime.metrics	Starting metrics server
2026-08-19T09:40:23Z	INFO	starting server	{"kind": "health probe", "addr": "[::]:8081"}
2026-08-19T09:40:23Z	INFO	controller-runtime.metrics	Serving metrics server	{"bindAddress": ":8080", "secure": false}
I0819 09:40:23.298935       1 leaderelection.go:250] attempting to acquire leader lease openshift-adp/oadp.openshift.io...
I0819 09:43:00.495089       1 leaderelection.go:260] successfully acquired lease openshift-adp/oadp.openshift.io
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1alpha1.DataProtectionApplication"}
2026-08-19T09:43:00Z	DEBUG	events	openshift-adp-controller-manager-5c6798467-tb6sc_9416b907-9342-4d3a-b2ac-35b5fab43c90 became leader	{"type": "Normal", "object": {"kind":"Lease","namespace":"openshift-adp","name":"oadp.openshift.io","uid":"4d5c7a56-ef79-409e-923e-6937b29643d8","apiVersion":"coordination.k8s.io/v1","resourceVersion":"328238"}, "reason": "LeaderElection"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.Deployment"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.BackupStorageLocation"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.VolumeSnapshotLocation"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.DaemonSet"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.SecurityContextConstraints"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.Service"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.Route"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.ConfigMap"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.Secret"}
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "source": "kind source: *v1.ConfigMap"}
2026-08-19T09:43:00Z	INFO	Starting Controller	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication"}
2026-08-19T09:43:00Z	INFO	cli-download-setup	Starting CLI download setup
2026-08-19T09:43:00Z	INFO	Starting EventSource	{"controller": "cloudstorage", "controllerGroup": "oadp.openshift.io", "controllerKind": "CloudStorage", "source": "kind source: *v1alpha1.CloudStorage"}
2026-08-19T09:43:00Z	INFO	Starting Controller	{"controller": "cloudstorage", "controllerGroup": "oadp.openshift.io", "controllerKind": "CloudStorage"}
2026-08-19T09:43:00Z	INFO	cli-download-setup	ConsoleCLIDownload already exists and is up-to-date	{"url": "https://oadp-cli-server-route-openshift-adp.apps.windows-prajoshi.mg.dog8code.com/"}
2026-08-19T09:43:00Z	INFO	cli-download-setup	CLI download setup completed successfully
2026-08-19T09:43:00Z	INFO	Starting workers	{"controller": "cloudstorage", "controllerGroup": "oadp.openshift.io", "controllerKind": "CloudStorage", "worker count": 1}
2026-08-19T09:43:00Z	INFO	Starting workers	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "worker count": 1}
2026-08-19T09:43:00Z	INFO	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "DataProtectionApplication": {"name":"ts-dpa","namespace":"openshift-adp"}, "namespace": "openshift-adp", "name": "ts-dpa", "reconcileID": "e2a11f12-ac3d-43af-82f3-d3769c9c9b62"}
2026-08-19T09:43:00Z	DEBUG	events	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"type": "Warning", "object": {"kind":"DataProtectionApplication","namespace":"openshift-adp","name":"ts-dpa","uid":"fe0fd89e-ad79-4fed-ba8f-83b0adb34b48","apiVersion":"oadp.openshift.io/v1alpha1","resourceVersion":"261390"}, "reason": "DeprecationResticConfig"}
2026-08-19T09:43:27Z	INFO	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "DataProtectionApplication": {"name":"ts-dpa","namespace":"openshift-adp"}, "namespace": "openshift-adp", "name": "ts-dpa", "reconcileID": "604aa660-df8c-434d-8c12-9a2ae7d0369f"}
2026-08-19T09:43:27Z	DEBUG	events	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"type": "Warning", "object": {"kind":"DataProtectionApplication","namespace":"openshift-adp","name":"ts-dpa","uid":"fe0fd89e-ad79-4fed-ba8f-83b0adb34b48","apiVersion":"oadp.openshift.io/v1alpha1","resourceVersion":"261390"}, "reason": "DeprecationResticConfig"}
2026-08-19T09:43:28Z	INFO	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "DataProtectionApplication": {"name":"ts-dpa","namespace":"openshift-adp"}, "namespace": "openshift-adp", "name": "ts-dpa", "reconcileID": "c3482bba-db48-4659-866d-a7ba5a5ab207"}
2026-08-19T09:43:28Z	DEBUG	events	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"type": "Warning", "object": {"kind":"DataProtectionApplication","namespace":"openshift-adp","name":"ts-dpa","uid":"fe0fd89e-ad79-4fed-ba8f-83b0adb34b48","apiVersion":"oadp.openshift.io/v1alpha1","resourceVersion":"261390"}, "reason": "DeprecationResticConfig"}
2026-08-19T09:44:27Z	INFO	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "DataProtectionApplication": {"name":"ts-dpa","namespace":"openshift-adp"}, "namespace": "openshift-adp", "name": "ts-dpa", "reconcileID": "f3a87040-03d5-4827-92d1-08b57caa65f4"}
2026-08-19T09:44:27Z	DEBUG	events	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"type": "Warning", "object": {"kind":"DataProtectionApplication","namespace":"openshift-adp","name":"ts-dpa","uid":"fe0fd89e-ad79-4fed-ba8f-83b0adb34b48","apiVersion":"oadp.openshift.io/v1alpha1","resourceVersion":"261390"}, "reason": "DeprecationResticConfig"}
2026-08-19T09:44:28Z	INFO	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"controller": "dataprotectionapplication", "controllerGroup": "oadp.openshift.io", "controllerKind": "DataProtectionApplication", "DataProtectionApplication": {"name":"ts-dpa","namespace":"openshift-adp"}, "namespace": "openshift-adp", "name": "ts-dpa", "reconcileID": "c0623864-cadf-4188-be0f-5789096341ff"}
2026-08-19T09:44:28Z	DEBUG	events	(Deprecation Warning) Use nodeAgent instead of restic, which is deprecated and will be removed in the future	{"type": "Warning", "object": {"kind":"DataProtectionApplication","namespace":"openshift-adp","name":"ts-dpa","uid":"fe0fd89e-ad79-4fed-ba8f-83b0adb34b48","apiVersion":"oadp.openshift.io/v1alpha1","resourceVersion":"261390"}, "reason": "DeprecationResticConfig"}

[openshift-ci]

@PrasadJoshi12: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[weshayutin]

/LGTM

[kaovilai]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, PrasadJoshi12, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment