Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-4924: Measure bootc build time and include build log in junit for failed builds #4211

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

USHIFT-4924: Measure bootc build time and include build log in junit for failed builds #4211

wants to merge 4 commits into from
+29 −12

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Nov 21, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmtk
Copy link
Member Author

pmtk commented Nov 21, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@pmtk: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-optional-components-rhel-eus

/test ocp-full-conformance-optional-components-rhel-eus-arm

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-rhel-eus-arm

/test ocp-full-conformance-serial-optional-components-rhel-eus

/test ocp-full-conformance-serial-optional-components-rhel-eus-arm

/test ocp-full-conformance-serial-rhel-eus

/test ocp-full-conformance-serial-rhel-eus-arm

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmtk
Copy link
Member Author

pmtk commented Nov 21, 2024

/test e2e-aws-tests-bootc

@pmtk
Copy link
Member Author

pmtk commented Nov 21, 2024

/test e2e-aws-tests-bootc

@pmtk pmtk changed the title Measure and record to junit bootc image build times Measure bootc build time and include build log in junit for failed builds Nov 21, 2024
@pmtk pmtk changed the title Measure bootc build time and include build log in junit for failed builds USHIFT-4924: Measure bootc build time and include build log in junit for failed builds Nov 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2024
@pmtk pmtk marked this pull request as ready for review November 21, 2024 11:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2024 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-4924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
ggiguash
ggiguash reviewed Nov 21, 2024
View reviewed changes
test/bin/pyutils/common.py
if log_filepath:
with open(log_filepath) as f:
desc = f.read()
append_file(JUNIT_LOGFILE, f'<failure message="{status}" type="${step}-failure">\n{desc}\n</failure>')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log files can be rather large. Do you see a problem with that?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@pmtk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-periodic-arm 0a91a04 link true /test e2e-aws-tests-bootc-periodic-arm
ci/prow/security 0a91a04 link false /test security
ci/prow/e2e-aws-tests-bootc-periodic 0a91a04 link true /test e2e-aws-tests-bootc-periodic
ci/prow/e2e-aws-tests-bootc-arm 0a91a04 link true /test e2e-aws-tests-bootc-arm
ci/prow/e2e-aws-tests-bootc 0a91a04 link true /test e2e-aws-tests-bootc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk pmtk marked this pull request as draft November 22, 2024 09:08
@pmtk
Copy link
Member Author

pmtk commented Nov 22, 2024

/test e2e-aws-tests-bootc

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash ggiguash left review comments

@dhensel-rh dhensel-rh Awaiting requested review from dhensel-rh

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmtk @openshift-ci-robot @ggiguash