Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-4892: Address Snyk issues #4184

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

vanhalenar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 15, 2024

@vanhalenar: This pull request references USHIFT-4892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vanhalenar
Once this PR has been reviewed and has the lgtm label, please assign agullon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar vanhalenar marked this pull request as ready for review November 15, 2024 11:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
@openshift-ci openshift-ci bot requested review from agullon and jogeo November 15, 2024 11:55
@vanhalenar vanhalenar changed the title USHIFT-4892: Exclude vendor paths from snyk scan USHIFT-4892: Exclude vendor paths from SNYK scan Nov 15, 2024
@vanhalenar vanhalenar marked this pull request as draft November 15, 2024 13:40
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
@vanhalenar vanhalenar changed the title USHIFT-4892: Exclude vendor paths from SNYK scan USHIFT-4892: Address Snyk issues Nov 15, 2024
@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

1 similar comment
@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

@vanhalenar
Copy link
Contributor Author

/test security

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@vanhalenar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants