OCPEDGE-2188: embed fencing validator into TNF MCO

[Neilhamza]

• What I did
  Added a new MachineConfig template file under templates/master/00-master/two-node-with-fencing/files/ that installs the fencing_validator.sh script to /usr/local/bin/ on control-plane nodes for Two-Node Fencing clusters.

• How to verify it

Deploy a Two-Node Fencing cluster.

Verify the MachineConfig for masters includes the new file.

On a master node, run:
oc debug node/ -- chroot /host ls -l /usr/local/bin/fencing_validator
oc debug node/ -- chroot /host /usr/local/bin/fencing_validator --help

copy it into the hypervisor:
oc debug node/ -- chroot /host cat /usr/local/bin/fencing_validator > fencing_validator

chmod +x fencing_validator
The script should be present, executable (0755), and runnable.

• Description for the changelog
  Ship /usr/local/bin/fencing_validator.sh via MCO for Two-Node Fencing clusters.

[openshift-ci-robot]

@Neilhamza: This pull request references OCPEDGE-2188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

• What I did
  Added a new MachineConfig template file under templates/master/00-master/two-node-with-fencing/files/ that installs the fencing_validator.sh script to /usr/local/bin/ on control-plane nodes for Two-Node Fencing clusters.

• How to verify it

Deploy a Two-Node Fencing cluster.

Verify the MachineConfig for masters includes the new file.

On a master node, run:

oc debug node/ -- chroot /host ls -l /usr/local/bin/fencing_validator.sh
oc debug node/ -- chroot /host /usr/local/bin/fencing_validator.sh --help

The script should be present, executable (0755), and runnable.

• Description for the changelog
  Ship /usr/local/bin/fencing_validator.sh via MCO for Two-Node Fencing clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@Neilhamza: This pull request references OCPEDGE-2188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

• What I did
  Added a new MachineConfig template file under templates/master/00-master/two-node-with-fencing/files/ that installs the fencing_validator.sh script to /usr/local/bin/ on control-plane nodes for Two-Node Fencing clusters.

• How to verify it

Deploy a Two-Node Fencing cluster.

Verify the MachineConfig for masters includes the new file.

On a master node, run:

oc debug node/ -- chroot /host ls -l /usr/local/bin/fencing_validator.sh
oc debug node/ -- chroot /host /usr/local/bin/fencing_validator.sh --help

The script should be present, executable (0755), and runnable.

• Description for the changelog
  Ship /usr/local/bin/fencing_validator.sh via MCO for Two-Node Fencing clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eggfoobar]

Looking good, I had some suggestions and questions. This is my initial pass, I'll give it another review once I deploy and test it on a cluster.

[openshift-ci-robot]

@Neilhamza: This pull request references OCPEDGE-2188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

• What I did
  Added a new MachineConfig template file under templates/master/00-master/two-node-with-fencing/files/ that installs the fencing_validator.sh script to /usr/local/bin/ on control-plane nodes for Two-Node Fencing clusters.

• How to verify it

Deploy a Two-Node Fencing cluster.

Verify the MachineConfig for masters includes the new file.

On a master node, run:

oc debug node/ -- chroot /host ls -l /usr/local/bin/fencing_validator.sh
oc debug node/ -- chroot /host /usr/local/bin/fencing_validator.sh --help

The script should be present, executable (0755), and runnable.

• Description for the changelog
  Ship /usr/local/bin/fencing_validator.sh via MCO for Two-Node Fencing clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@Neilhamza: This pull request references OCPEDGE-2188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

• What I did
  Added a new MachineConfig template file under templates/master/00-master/two-node-with-fencing/files/ that installs the fencing_validator.sh script to /usr/local/bin/ on control-plane nodes for Two-Node Fencing clusters.

• How to verify it

Deploy a Two-Node Fencing cluster.

Verify the MachineConfig for masters includes the new file.

On a master node, run:
oc debug node/ -- chroot /host ls -l /usr/local/bin/fencing_validator
oc debug node/ -- chroot /host /usr/local/bin/fencing_validator --help

copy it into the hypervisor:
oc debug node/ -- chroot /host cat /usr/local/bin/fencing_validator > fencing_validator

chmod +x fencing_validator
The script should be present, executable (0755), and runnable.

• Description for the changelog
  Ship /usr/local/bin/fencing_validator.sh via MCO for Two-Node Fencing clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eggfoobar]

Just had some more minor suggestinos

[eggfoobar]

Looking good, had some small suggestions

[Neilhamza]

done

[eggfoobar]

/test e2e-metal-ovn-two-node-fencing

[eggfoobar]

/lgtm

[pablintino]

/approve
/verified by e2e-metal-ovn-two-node-fencing

[openshift-ci-robot]

@pablintino: This PR has been marked as verified by e2e-metal-ovn-two-node-fencing.

In response to this:

/approve
/verified by e2e-metal-ovn-two-node-fencing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, Neilhamza, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pablintino]

/retest-required

[openshift-ci]

@Neilhamza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	dd6b9ca	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-mco-disruptive	dd6b9ca	link	false	/test e2e-aws-mco-disruptive
ci/prow/e2e-azure-ovn-upgrade-out-of-change	dd6b9ca	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl	dd6b9ca	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-metal-ovn-two-node-fencing	dd6b9ca	link	false	/test e2e-metal-ovn-two-node-fencing

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.