Logging-ui-plugin test using real data #305

anpingli · 2025-10-13T07:28:05Z

Run Logging UI test using real test data
defined an individual entrypoint run-cypress-logging.sh
update cypress:run:ci and web/cypress.config.ts to make the CI run as-is.
Test Logging using both cluster-admin and common users
Run Logging test on both Admin Console and Dev Console
Run Logging test on both Observer->Logs, and Pod->aggr logs

openshift-ci · 2025-10-13T07:28:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anpingli
Once this PR has been reviewed and has the lgtm label, please assign zhuje for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zhuje · 2025-11-24T16:11:04Z

/retest

zhuje · 2025-11-24T16:37:31Z

@anpingli There are some errors coming from the package-lock.json file, this is from prow logs:

npm error "npm ci" can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with "npm install" before continuing. npm error

anpingli · 2025-12-03T14:11:21Z

/retest-required

zhuje · 2025-12-03T15:05:24Z

/retest

openshift-ci · 2025-12-04T06:28:24Z

@anpingli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

anpingli · 2025-12-04T07:39:13Z

@zhuje All test pass now.

anpingli · 2025-12-10T10:06:31Z

@jgbernalp could you talk a look my PR?

jgbernalp · 2025-12-10T14:57:40Z

LGTM
@etmurasaki can you review if this is in line with what we have for other plugins

jgbernalp · 2025-12-10T15:25:06Z

web/cypress/e2e/logging/logs-adminConsole-ObserveLogs-admin.cy.ts

+
+  beforeEach( function() {
+    // Load the other page to ensure Observe-Logs in clean status
+    cy.get('section.pf-v6-c-nav__subnav').contains('a','Search').click();


we prefer to use test ids, so we don't depend on specific patternfly claseses. Which might change.

jgbernalp · 2025-12-10T15:26:24Z

web/cypress/e2e/logging/logs-adminConsole-ObserveLogs-admin.cy.ts

+    const pattern = new RegExp(`${APP_NAMESPACE1}|${APP_NAMESPACE2}`);
+    cy.getByTestId(TestIds.LogsTable).within(() => {
+      //  Click the first expand button
+      cy.get('#expand.pf-v5-c-table__td.lv-plugin__table__expand.pf-v5-c-table__toggle', { timeout: 6000 })


same here, it seems we are mixing pf6 and pf5 selectors. A better way would be to add a test id to the logs table so we can reference it directly.

etmurasaki · 2025-12-10T19:35:26Z

web/cypress/e2e/logging/logs-adminConsole-AggregatedLogs-admin.cy.ts

+
+  it('Log Panel top elements', {tags:['@smoke','@aggr']} , () => {
+    //load Aggregated Logs for the first pod in APP_NAMESPACE1
+    cy.get('[data-test-id="namespace-bar-dropdown"]')


repeated steps like this we can make them reusable in a "utils.ts" file as a "Page Object" concept where you can pass namespace as parameter and do not hardcode it

etmurasaki · 2025-12-10T19:42:24Z

web/cypress/e2e/logging/logs-adminConsole-AggregatedLogs-admin.cy.ts

+      .first()
+      .find('a.co-resource-item__resource-name')
+      .click();
+    cy.get('a[data-test-id="horizontal-link-Aggregated Logs"]').click();


as @jgbernalp had mentioned before, these data-test-id, data-id (when MaterialUI if Logging also uses), and other locators could be also be in the same /src/test-ids file in another "json object" like DataTestIds, DataIds, Classes, then according to the type you can create different selectors cy.getByDataTestId, cy.getByDataIds, cy.getByClasses and refer to them.

When handling with Classes, you can refer both pf5 and pf6. You can take a look at this file as example: https://github.com/openshift/monitoring-plugin/blob/main/web/src/components/data-test.ts

Good suggestion. Let me define similar data-test.ts for Logging.

etmurasaki · 2025-12-10T19:47:32Z

web/cypress/e2e/logging/logs-adminConsole-AggregatedLogs-admin.cy.ts

+      .click();
+    cy.get('a[data-test-id="horizontal-link-Aggregated Logs"]').click();
+
+    cy.getByTestId(TestIds.ToggleHistogramButton).should('exist');


an example of reusable steps would be these assertions cross different user types or cross different pages, for example Logs and Aggregated Logs probably have many common components. This way, if something breaks one of the pages by any reason, you could also detect and fix it easily in one place.

I didn't take a look at all cypress test files, but I have a feeling they are very similar in general and maybe one or another difference depending on the page (Logs or Agg Logs) and/or per user type. So, these steps could become more than reused.

I know it would be a pain now to refactor, decouple all these steps, but I am sure it worth as a short/mid/long term, specially if you need to backport all these files of 2 Logging versions and/or upgrade patternfly from 4/5 to 6 and future ones.

I had defined a common function in this cypress/e2e/logging/logs-common-test.cy.ts which can be called in different page.

etmurasaki · 2025-12-11T11:29:37Z

web/cypress/support/commands.ts

+        }
+      })
+      cy.get('[data-test-id="perspective-switcher-toggle"]').invoke('text').then((text) => {
+          if (text == "Administrator" ) {


already in 4.21 nightly builds, you are going to see "Core platform" instead of Administrator.
Monitoring-plugin and distributed tracing repos, we have something like https://github.com/openshift/monitoring-plugin/blob/e35027e4e122dc1b70ce2584a13d1f20e5948576/web/cypress/support/commands/auth-commands.ts#L120 to pass in your test instead of hardcode in your test file.

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025

openshift-ci bot requested review from kyoto and zhuje October 13, 2025 07:28

anpingli force-pushed the real-user-test branch from 5e598ce to 74d54a2 Compare October 13, 2025 07:30

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025

anpingli changed the title ~~Logging-ui-plugin test using real user~~ [WIP]Logging-ui-plugin test using real user Oct 13, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025

anpingli force-pushed the real-user-test branch 8 times, most recently from 86bc31f to 856f0b1 Compare November 24, 2025 10:17

anpingli force-pushed the real-user-test branch 9 times, most recently from 3294a38 to cf23167 Compare December 3, 2025 13:27

anpingli changed the title ~~[WIP]Logging-ui-plugin test using real user~~ ]Logging-ui-plugin test using real data Dec 3, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2025

anpingli changed the title ~~]Logging-ui-plugin test using real data~~ Logging-ui-plugin test using real data Dec 3, 2025

anpingli force-pushed the real-user-test branch from cf23167 to cc7ed85 Compare December 3, 2025 13:40

anpingli force-pushed the real-user-test branch from cc7ed85 to 842a813 Compare December 3, 2025 14:53

anpingli force-pushed the real-user-test branch 11 times, most recently from a5011dc to 9a13df3 Compare December 4, 2025 06:13

Execute Logging-UI with prepare data

27d9043

anpingli force-pushed the real-user-test branch from 9a13df3 to 27d9043 Compare December 4, 2025 06:18

jgbernalp reviewed Dec 10, 2025

View reviewed changes

etmurasaki reviewed Dec 10, 2025

View reviewed changes

etmurasaki reviewed Dec 11, 2025

View reviewed changes

Logging-ui-plugin test using real data #305

Are you sure you want to change the base?

Logging-ui-plugin test using real data #305

Uh oh!

Conversation

anpingli commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

zhuje commented Nov 24, 2025

Uh oh!

zhuje commented Nov 24, 2025

Uh oh!

anpingli commented Dec 3, 2025

Uh oh!

zhuje commented Dec 3, 2025

Uh oh!

openshift-ci bot commented Dec 4, 2025

Uh oh!

anpingli commented Dec 4, 2025

Uh oh!

anpingli commented Dec 10, 2025

Uh oh!

jgbernalp commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anpingli commented Oct 13, 2025 •

edited

Loading