Skip to content

CORS-4082, CORS-4086: Azure UserProvisionedDNS: Update bootstrap, master and worker ignition files #10058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CORS-4082, CORS-4086: Azure UserProvisionedDNS: Update bootstrap, master and worker ignition files #10058

wants to merge 2 commits into from
+79 −9

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Nov 3, 2025

  1. Edit bootstrap, master and worker ignition files after they have been created using EditIgnition() which was created as a common method for all platforms supporting this feature
  2. Provide EditIgnition() with the api and api-int LB IPs for Azure
  3. Stop creating DNS entries for Azure when userProvisionedDNS is enabled

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2025 •
edited by openshift-ci bot
Loading

@sadasu: This pull request references CORS-4082 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  1. Edit bootstrap, master and worker ignition files after they have been created using EditIgnition() which was created as a common method for all platforms supporting this feature
  2. Provide EditIgnition() with the api and api-int LB IPs for Azure
  3. Stop creating DNS entries for Azure when userProvisionedDNS is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rna-afk and rwsu November 3, 2025 18:00
@sadasu
Copy link
Contributor Author

sadasu commented Nov 3, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2025 •
edited by openshift-ci bot
Loading

@sadasu: This pull request references CORS-4082 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu sadasu changed the title CORS-4082: Azure UserProvisionedDNS: Update bootstrap, master and worker ignition files CORS-4082, CORS-4086: Azure UserProvisionedDNS: Update bootstrap, master and worker ignition files Nov 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2025 •
edited by openshift-ci bot
Loading

@sadasu: This pull request references CORS-4082 which is a valid jira issue.

This pull request references CORS-4086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  1. Edit bootstrap, master and worker ignition files after they have been created using EditIgnition() which was created as a common method for all platforms supporting this feature
  2. Provide EditIgnition() with the api and api-int LB IPs for Azure
  3. Stop creating DNS entries for Azure when userProvisionedDNS is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link
Contributor Author

sadasu commented Nov 3, 2025

/retest-required

@sadasu
Copy link
Contributor Author

sadasu commented Nov 3, 2025

/jira-refresh

tthvo
tthvo reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have some code questions 👍

@tthvo
Copy link
Member

tthvo commented Nov 3, 2025

/cc @jhixson74 @patrickdillon

patrickdillon
patrickdillon reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@sadasu sadasu force-pushed the azure-custom-dns branch 2 times, most recently from 4a331ef to 8fd2272 Compare November 6, 2025 20:54
tthvo
tthvo reviewed Nov 6, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
sadasu added 2 commits November 7, 2025 10:30
@sadasu
Azure UserProvisionedDNS: Update bootstrap, master and worker ignitio…
353f7d2 
…n files

1. Edit bootstrap, master and worker ignition files after they have
been created using EditIgnition() which was created as a common method
for all platforms supporting this feature
2. Provide EditIgnition() with the api and api-int LB IPs for Azure
3. Stop creating DNS entries for Azure when userProvisionedDNS is
enabled
@sadasu
Azure UserProvisionedDNS: Copy CoreDNS pod resources for MCO bootstrap
f485341 
Copy the CoreDNS pod definifion and Corefile to correct location on
bootstrap node during bootkube. That way MCO running on the bootstrap
node can start the CoreDNS pod.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
tthvo
tthvo reviewed Nov 7, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@sadasu
Copy link
Contributor Author

sadasu commented Nov 7, 2025

/retest-required

@tthvo
Copy link
Member

tthvo commented Nov 8, 2025

/test e2e-azure-ovn

Uh ohh, what's going on... 👀

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2025

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-shared-vpc f485341 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack f485341 link false /test e2e-azurestack
ci/prow/azure-ovn-marketplace-images f485341 link false /test azure-ovn-marketplace-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@rna-afk rna-afk Awaiting requested review from rna-afk

@rwsu rwsu Awaiting requested review from rwsu

@jhixson74 jhixson74 Awaiting requested review from jhixson74

+1 more reviewer

@tthvo tthvo tthvo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tthvo tthvo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sadasu @openshift-ci-robot @tthvo @patrickdillon