Skip to content

[release-4.17] OCPBUGS-53236: Validation for API and Ingress VIPs when using user-managed load balancer #10047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2025
Merged

[release-4.17] OCPBUGS-53236: Validation for API and Ingress VIPs when using user-managed load balancer #10047

merged 5 commits into from
Nov 7, 2025

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Oct 30, 2025

  • Prevent default API and Ingress VIP generation for user-managed load balancers
  • Add default load balancer if none is specified
  • Add unit tests for OpenStack platform defaults
  • Edit manifest test
  • OCPBUGS-56079: apply fixes for yaml-lint errors

dkokkino and others added 5 commits October 30, 2025 11:51
@stephenfin
Prevent default API and Ingress VIP generation for user-managed load …
eeb7c74 
…balancers

 - Previously, when API and Ingress VIPs were not specified, default values were automatically
 generated for user-managed load balancers.This was unintended behavior.
 Now, if the user does not explicitly provide API and Ingress VIPs, a fatal error is thrown instead.
@stephenfin
Add default load balancer if none is specified
832e028 
 -If no load balancer is provided, a default OpenShift load balancer is
 now assigned automatically. This ensures proper handling and avoids
 misconfigurations.
@stephenfin
Add unit tests for OpenStack platform defaults
bb9e4f8 
Adds unit tests in platform_test.py to verify OpenStack platform defaults.
Covers cases such as:
- Assigning a default OpenShift-managed load balancer when none is specified
- Handling user-managed load balancers with and without VIPs
- Ensuring correct API and Ingress VIP assignments
@stephenfin
Edit manifest test
0d92b26 
- lb-default-stable: As a default load balancer is now being assigned when one is not provided this test needs to be updated to reflect that change
- lb-unmanaged: I made changes to how the defaults are set. If the load
  balancer is user-managed VIPs will not automatically be assigned
  anymore. This change needs to be reflected in this test by adding a
  apiVIPs and ingressVIPs value to the install-config
@tthvo @stephenfin
OCPBUGS-56079: apply fixes for yaml-lint errors
a741f5d 
Notes: there are other yaml-lint warnings but they've been there for a
long time. This commit only focuses on the errors introduced during 4.19
cycle.

Conflicts:
  .golangci.yaml

NOTE(stephenfin): Changes to .golangci.yaml were removed because they
don't apply here.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2025

@stephenfin: This pull request references Jira Issue OCPBUGS-53236, which is invalid:

  • expected dependent Jira Issue OCPBUGS-53235 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Prevent default API and Ingress VIP generation for user-managed load balancers
  • Add default load balancer if none is specified
  • Add unit tests for OpenStack platform defaults
  • Edit manifest test
  • OCPBUGS-56079: apply fixes for yaml-lint errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin stephenfin mentioned this pull request Oct 30, 2025
Closed
mandre
mandre reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025 •
edited
Loading

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy a741f5d link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 3, 2025

/test e2e-openstack-ovn

Hopefully the cloud is quiet

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 3, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2025

@stephenfin: This pull request references Jira Issue OCPBUGS-53236, which is invalid:

  • expected dependent Jira Issue OCPBUGS-53235 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 7, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2025

@stephenfin: This pull request references Jira Issue OCPBUGS-53236, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-53235 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-53235 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 7, 2025

/label backport-risk-assessed
/verified by CI

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 7, 2025
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2025

@stephenfin: This PR has been marked as verified by CI.

In response to this:

/label backport-risk-assessed
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 64d3580 into openshift:release-4.17 Nov 7, 2025
19 of 20 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the cherry-pick-9571-to-release-4.17 branch November 7, 2025 11:17
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2025

@stephenfin: Jira Issue Verification Checks: Jira Issue OCPBUGS-53236
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-53236 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

  • Prevent default API and Ingress VIP generation for user-managed load balancers
  • Add default load balancer if none is specified
  • Add unit tests for OpenStack platform defaults
  • Edit manifest test
  • OCPBUGS-56079: apply fixes for yaml-lint errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephenfin @openshift-ci-robot @mandre @tthvo