OCPBUGS-63584: vSphere-don't use template,ClusterOSImage together

[jcpowermac]

This commit adds validation for vSphere.
Failure Domain templates should not be used
together with ClusterOSImage.

Co-Authored-By: Cursor [email protected]

[openshift-ci-robot]

@jcpowermac: This pull request references Jira Issue OCPBUGS-63584, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit adds validation for vSphere.
Failure Domain templates should not be used
together with ClusterOSImage.

Co-Authored-By: Cursor [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/types/vsphere/validation/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcpowermac]

/jira refresh

[openshift-ci-robot]

@jcpowermac: This pull request references Jira Issue OCPBUGS-63584, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/golint	b889ece	link	true	/test golint
ci/prow/okd-scos-e2e-aws-ovn	b889ece	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-zones	b889ece	link	false	/test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-hybrid-env	b889ece	link	false	/test e2e-vsphere-ovn-hybrid-env

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tthvo]

I just have a few suggestions, but looks good! Would it be OK to add some unit tests for the check 🙏?

[tthvo]

Looks like we ran into another "too-many-if" problem: ci/prow/golint

pkg/types/vsphere/validation/platform.go:154:1: cyclomatic complexity 50 of func `validateFailureDomains` is high (> 30) (gocyclo)
func validateFailureDomains(p *vsphere.Platform, platformFldPath *field.Path, fldPath *field.Path, isLegacyUpi bool) field.ErrorList {
^ 

I think it's fine since there are lots of checks. We can bypass the lint. WDYT?

Suggested change

	func validateFailureDomains(p *vsphere.Platform, platformFldPath *field.Path, fldPath *field.Path, isLegacyUpi bool) field.ErrorList {
	func validateFailureDomains(p *vsphere.Platform, platformFldPath *field.Path, fldPath *field.Path, isLegacyUpi bool) field.ErrorList { //nolint:gocyclo

[tthvo]

Suggested change

	allErrs = append(allErrs, field.Invalid(topologyFld.Child("template"), failureDomain.Topology.Template, "cannot be specified when clusterOSImage is set"))
	allErrs = append(allErrs, field.Invalid(platformFldPath.Child("clusterOSImage"), p.ClusterOSImage, "cannot be specified when template is set"))
	allErrs = append(allErrs, field.Invalid(topologyFld.Child("template"), failureDomain.Topology.Template, "cannot be specified when clusterOSImage is set"))
	allErrs = append(allErrs, field.Invalid(platformFldPath.Child("clusterOSImage"), p.ClusterOSImage, "cannot be specified when failuredomain.topology.template is set"))

nit: maybe we can distinguish failure domain topology "template" from other templates?