OCPBUGS-59105: pkg/asset/manifests/azure: save cidr blocks #10034
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@jhixson74: This pull request references Jira Issue OCPBUGS-59105, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When using a pre-existing network, save CIDR blocks for the virtual network and subnets https://issues.redhat.com/browse/OCPBUGS-59105
jhixson74
force-pushed
the
main-azure-OCPBUGS-59105
branch
from
63e4167 to
451f37a
Compare
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@jhixson74: This pull request references Jira Issue OCPBUGS-59105, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@jhixson74: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I am doing most of this in #9773 . Any chance we could merge this with that work? |
|
pre-merge tested, installation with pre-created vnet (network configuration was same with bug) succeeded. /verified by jima |
openshift-ci-robot
added
the
verified
|
@jinyunma: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tthvo
left a comment
tthvo
left a comment
There was a problem hiding this comment.
I just have a small question above ⬆️ and ci/prow/golint is current not happy 😓 Maybe it prefers make([]slice, len) and a bit other simplification.
There is also a comment from Aditya #10034 (comment) 👀
| }, | ||
| }} | ||
| if installConfig.Config.Azure.VirtualNetwork != "" { | ||
| virtualNetworkAddressPrefixes := []string{} |
There was a problem hiding this comment.
This new declaration of virtualNetworkAddressPrefixes will mask the one defined on line 45. But it is not being used anyway outside the if block...Is it intended?
ci/prow/golint is also complaining:
pkg/asset/manifests/azure/cluster.go:181:37: SA4010: this result of append is never used, except maybe in other appends (staticcheck)
virtualNetworkAddressPrefixes = append(virtualNetworkAddressPrefixes, addressPrefix)
There was a problem hiding this comment.
IIUC, it means the result in this block is not being used and the virtualNetworkAddressPrefixes will always be set to the "main" CIDR.
5 participants
When using a pre-existing network, save CIDR blocks for the virtual network and subnets
https://issues.redhat.com/browse/OCPBUGS-59105