Skip to content

[release-4.16] OCPBUGS-54165: aws: fix NLB creation in secret regions #10031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] OCPBUGS-54165: aws: fix NLB creation in secret regions #10031

wants to merge 5 commits into from

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Oct 24, 2025

This is a manual cherry-pick of #9071, replacing #9595.

tthvo and others added 5 commits October 24, 2025 14:09
@tthvo
deps: bump CAPA to commit with NLB SG fix
180a7cb 
Commit: kubernetes-sigs/cluster-api-provider-aws@6694294

Notes: there are no updates to the AWS infra CRD
@r4f4 @tthvo
infra/aws: remove apiHost condition on Load Balancer
9e78d52 
This is leftover from before CAPA had support for a public LB as the
secondary controlPlane load balancer. We had to configure the AWSCluster
in such a way the primary load balancer would either be `InternetFacing`
if publish was set to "External" or `Internal` otherwise.

Now the primary LB is always `Internal` and the secondary LB only exists
when publish is "External".
@r4f4 @tthvo
aws: refactor CreateOrUpdateRecord function
8a3cb9d 
This function was doing way more than its name says: it was creating
records in both private and public zones. The argument names were also
not very descriptive and very hard to decipher at a glance.

This change moves the logic out of the function and into the aws
`InfraReady` hook. This not only makes the logic more readable, but it
also paves the way for the use of Classic Load Balancer types.
@r4f4 @tthvo
aws: move owned tag creation to CreateHostedZone
b8f0ea1 
Tagging the resource as "owned" should be part of the creation.
@r4f4 @tthvo
ic: aws: document createRecord input fields.
f8081ce 
This should remove any ambiguity/misunderstanding when the field names
are not clear enough.
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

@tthvo: This pull request references Jira Issue OCPBUGS-54165, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-53459 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-53459 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

Requesting review from QA contact:
/cc @yunjiang29

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #9071, replacing #9595.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yunjiang29 October 24, 2025 21:11
@tthvo tthvo mentioned this pull request Oct 24, 2025
Closed
@tthvo
Copy link
Member Author

tthvo commented Oct 24, 2025

/cc @sadasu @barbacbd

@openshift-ci openshift-ci bot requested review from barbacbd and sadasu October 24, 2025 21:12
@tthvo
Copy link
Member Author

tthvo commented Oct 24, 2025

/label platform/aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2025

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn f8081ce link false /test altinfra-e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones f8081ce link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/okd-scos-e2e-vsphere-ovn f8081ce link false /test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

patrickdillon commented Oct 27, 2025

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 27, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
@yunjiang29
Copy link
Contributor

yunjiang29 commented Oct 29, 2025

The pre-merge test is ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yunjiang29 yunjiang29 Awaiting requested review from yunjiang29

@bfournie bfournie Awaiting requested review from bfournie

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@barbacbd barbacbd Awaiting requested review from barbacbd

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/aws

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tthvo @openshift-ci-robot @patrickdillon @yunjiang29 @r4f4