HIVE-3025: fix adopted metadata.json secret name

[2uasimojo]

This was a copy/paste error from HIVE-2302 / #2729.

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-3023 which is a valid jira issue.

In response to this:

This was a copy/paste error from HIVE-2302 / #2729.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-3023 which is a valid jira issue.

In response to this:

This was a copy/paste error from HIVE-2302 / #2729.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[2uasimojo]

/assign @huangmingxia
/cc @jianping-shu this may help you validate #2805 :)

[huangmingxia]

/lgtm

Local test passed.

 % cat pkg/clusterresource/builder.go | grep metadata-json
	return fmt.Sprintf("%s-adopted-metadata-json", o.Name)

 %  ./bin/hiveutil create-cluster mihuangadpot --cloud=aws --adopt --adopt-admin-kubeconfig=./kubeconfig3  --adopt-metadata-json=./metadata.json --adopt-cluster-id=xxx --adopt-infra-id=xxx -o yaml > 3025.yaml

secret has been correctly generated.
 % cat 3025.yaml
...
- apiVersion: v1
  data:
    metadata.json: xxx
  kind: Secret
  metadata:
    creationTimestamp: null
    name: mihuangadpot-adopted-metadata-json
...

 % echo "xxx" | base64 -d | jq .
{
  "clusterName": "xxx",
  "clusterID": "xxx",
  "infraID": "xxx",
  "aws": {
    "region": "ap-northeast-1",
    "identifier": [
      {
        "kubernetes.io/cluster/xxx": "owned"
      },
      {
        "openshiftClusterID": "xxx"
      },
      {
        "sigs.k8s.io/cluster-api-provider-aws/cluster/xxx": "owned"
      }
    ],
    "clusterDomain": "cluster.base.domain.com"
  },
  "featureSet": "",
  "customFeatureSet": null
}

[huangmingxia]

/retitle HIVE-3025: fix adopted metadata.json secret name

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-3025 which is a valid jira issue.

In response to this:

This was a copy/paste error from HIVE-2302 / #2729.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.39%. Comparing base (e597cf4) to head (0ac3a5f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/clusterresource/builder.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2812   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files         279      279           
  Lines       34190    34190           
=======================================
  Hits        17231    17231           
  Misses      15595    15595           
  Partials     1364     1364           

Files with missing lines	Coverage Δ
pkg/clusterresource/builder.go	63.02% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[2uasimojo]

/retest hive-mce-210-on-pull-request

[2uasimojo]

The bare "Red Hat Konflux" job is bogus. I would override it, but I need to re-push anyway cause I made a typo in the commit message. Since I'm not changing content, I'll force-merge at that point.

[huangmingxia]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, huangmingxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.