Skip to content

Conversation

@jianping-shu
Copy link
Contributor

@jianping-shu jianping-shu commented Dec 9, 2025

Testing HIVE-2706 feature and userProvisionedDNS in install-config didn't take effect.
In debugging, login on provision pod:
check the /installconfig/install-config.yaml, ok
mkdir an new folder
copy /installconfig/install-config.yaml to the new folder(And update pullSecret)
Run ./openshift-install create manifests --dir
Check cluster-api/02_azure-cluster.yaml, it is "privateDNSZone: None" now

This PR to keep one copy of install-config.yaml for debugging.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2025
@openshift-ci openshift-ci bot requested review from 2uasimojo and jstuever December 9, 2025 04:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianping-shu
Once this PR has been reviewed and has the lgtm label, please assign dlom for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2025

@jianping-shu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.39%. Comparing base (6648a44) to head (b114dae).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/installmanager/installmanager.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2810      +/-   ##
==========================================
- Coverage   50.39%   50.39%   -0.01%     
==========================================
  Files         279      279              
  Lines       34190    34192       +2     
==========================================
  Hits        17231    17231              
- Misses      15595    15596       +1     
- Partials     1364     1365       +1     
Files with missing lines Coverage Δ
pkg/installmanager/installmanager.go 35.93% <0.00%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jianping-shu jianping-shu deleted the tmp-backup-installconfig-forcheck branch December 10, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant