HIVE-3014: Revendor installer to v1.4.21-pre

[dlom]

xref: HIVE-3014
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

[openshift-ci-robot]

@dlom: This pull request references HIVE-3014 which is a valid jira issue.

In response to this:

xref: HIVE-3014
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dlom: This pull request references HIVE-3014 which is a valid jira issue.

In response to this:

xref: HIVE-3014
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.39%. Comparing base (6104f29) to head (1bc94c2).
⚠️ Report is 12 commits behind head on master.

Files with missing lines	Patch %	Lines
...ller/clusterrelocate/clusterrelocate_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
+ Coverage   50.35%   50.39%   +0.03%     
==========================================
  Files         279      279              
  Lines       34180    34195      +15     
==========================================
+ Hits        17210    17231      +21     
+ Misses      15617    15604      -13     
- Partials     1353     1360       +7     

Files with missing lines	Coverage Δ
pkg/controller/machinepool/awsactuator.go	77.86% <100.00%> (ø)
pkg/controller/machinepool/azureactuator.go	69.53% <100.00%> (-0.87%)	⬇️
pkg/controller/machinepool/nutanixactuator.go	84.28% <100.00%> (+0.22%)	⬆️
...ller/clusterrelocate/clusterrelocate_controller.go	40.96% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[2uasimojo]

I'm going to hope that these validation budget checks were enabled by accident, temporarily.

/retest-required

[2uasimojo]

Ugh. @JoelSpeed what are we supposed to do about this?

Also, why is it complaining about an int64 field? Or does that just happen to be the point at which the whole budget got pushed over the edge?

[dlom]

Failing on the same The CustomResourceDefinition "clusterdeployments.hive.openshift.io" is invalid:

I see we're patching CRDs already to remove some things, should we do the same here? @2uasimojo

[JoelSpeed]

You need a max length on

hive/apis/hive/v1/clusterdeployment_types.go

Line 138 in 140ebad

Ingress []ClusterIngress `json:"ingress,omitempty"`

At the moment it's estimating the worst case as 3MiB over whatever the smallest object there is ({"name":"","domain":""} 23 chars) so approx 137k list entries. So every validation that exists in that list is 137k times larger than in o/api.

What's a sensible number of maximum ingresses you could retrofit to solve this without causing real world issues?

[2uasimojo]

/test e2e-openstack

[dlom]

/test e2e-openstack

[dlom]

/test e2e-azure

[dlom]

/retest

[2uasimojo]

/retest

[red-hat-konflux]

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
hive-mce-210-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-211-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-26-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-27-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-28-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-mce-29-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request
hive-on-pull-request	CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/|\\\\.md$|^(?:.*/)?(?:\\\\.gitignore|OWNERS|PROJECT|LICENSE)$'))\n" failed to evaluate: no such key: pull_request

[dlom]

/test e2e-openstack

[dlom]

/retest-required

[2uasimojo]

/retest-required

[dlom]

/test e2e-openstack

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[dlom]

/test e2e-azure

[openshift-ci]

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.