Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show commit status in commit list row #295

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

rottencandy
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/HAC-2620

Description

Show commit status in commit list rows in the commits list page.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

0
1

How to test or reproduce?

Go to commits list page.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #295 (8aca367) into main (0f1e378) will increase coverage by 0.94%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   73.81%   74.75%   +0.94%     
==========================================
  Files         430      431       +1     
  Lines        9025     9120      +95     
  Branches     2417     2461      +44     
==========================================
+ Hits         6662     6818     +156     
+ Misses       2226     2173      -53     
+ Partials      137      129       -8     
Impacted Files Coverage Δ
src/components/Commits/CommitSidePanelHeader.tsx 73.91% <ø> (-1.09%) ⬇️
...mponents/Commits/__data__/pipeline-with-commits.ts 100.00% <ø> (ø)
src/components/Commits/CommitDetailsView.tsx 89.58% <100.00%> (+0.22%) ⬆️
src/components/Commits/CommitsListRow.tsx 95.83% <100.00%> (+0.83%) ⬆️
src/components/Commits/commit-status.ts 100.00% <100.00%> (ø)
src/utils/flag-utils.ts 68.00% <0.00%> (-25.75%) ⬇️
...onents/PipelineRunListView/pipelinerun-actions.tsx 71.42% <0.00%> (-11.91%) ⬇️
...nts/ApplicationDetailsView/ApplicationSwitcher.tsx 89.47% <0.00%> (-4.65%) ⬇️
...overview/visualization/hooks/useAppWorkflowData.ts 95.71% <0.00%> (-4.29%) ⬇️
src/utils/pipeline-utils.ts 93.33% <0.00%> (-3.10%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1e378...8aca367. Read the comment docs.

@rottencandy rottencandy force-pushed the fix/commit-status-2620 branch from 3683f44 to 8aca367 Compare January 4, 2023 09:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

@rottencandy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@rottencandy
Copy link
Contributor Author

/cc @rohitkrai03

@openshift-ci openshift-ci bot requested a review from rohitkrai03 January 4, 2023 11:02
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@rohitkrai03 rohitkrai03 merged commit 7a1dd42 into openshift:main Jan 6, 2023
@rottencandy rottencandy deleted the fix/commit-status-2620 branch April 26, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants