Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Context Switcher to Application details view #289

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

sahil143
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/HAC-2622

Description

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

image

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #289 (1f20468) into main (29c78a1) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   74.15%   74.15%           
=======================================
  Files         430      430           
  Lines        9066     9070    +4     
  Branches     2438     2443    +5     
=======================================
+ Hits         6723     6726    +3     
- Misses       2207     2208    +1     
  Partials      136      136           
Impacted Files Coverage Δ
...nts/ApplicationDetailsView/ApplicationSwitcher.tsx 89.47% <66.66%> (-4.65%) ⬇️
...mponents/ApplicationDetails/ApplicationDetails.tsx 81.13% <100.00%> (+0.36%) ⬆️
src/components/ApplicationDetails/DetailsPage.tsx 96.36% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c78a1...1f20468. Read the comment docs.

@rottencandy rottencandy mentioned this pull request Dec 20, 2022
5 tasks
Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I click on already selected application, the params are removed.
Maybe we can avoid running callback if a key is already selected?

recording-1671522482.mp4

@sahil143
Copy link
Contributor Author

If I click on already selected application, the params are removed.
Maybe we can avoid running callback if a key is already selected?

@rottencandy fixed!

Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022
@rohitkrai03
Copy link
Contributor

@sahil143 You've got some conflicts after merging your other PR.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2022
@sahil143 sahil143 force-pushed the application-switcher branch from 10dd8e4 to 1f20468 Compare December 23, 2022 09:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

@sahil143: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2022
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@rohitkrai03 rohitkrai03 merged commit 1f8931e into openshift:main Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants