-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Context Switcher to Application details view #289
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 430 430
Lines 9066 9070 +4
Branches 2438 2443 +5
=======================================
+ Hits 6723 6726 +3
- Misses 2207 2208 +1
Partials 136 136
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I click on already selected application, the params are removed.
Maybe we can avoid running callback if a key is already selected?
recording-1671522482.mp4
@rottencandy fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sahil143 You've got some conflicts after merging your other PR. |
10dd8e4
to
1f20468
Compare
@sahil143: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, rottencandy, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes
https://issues.redhat.com/browse/HAC-2622
Description
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: