Skip to content

OCPBUGS-92747: CVE-2026-46597 openshift4/ose-console: golang.org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.15.z] - #16962

Open
tonyxrmdavidson wants to merge 3 commits into
openshift:release-4.15from
tonyxrmdavidson:OCPBUGS-92747-CVE-2026-46597-4-15
Open

OCPBUGS-92747: CVE-2026-46597 openshift4/ose-console: golang.org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.15.z]#16962
tonyxrmdavidson wants to merge 3 commits into
openshift:release-4.15from
tonyxrmdavidson:OCPBUGS-92747-CVE-2026-46597-4-15

Conversation

@tonyxrmdavidson

Copy link
Copy Markdown

OCPBUGS-92747: CVE-2026-46597 — golang.org/x/crypto/ssh Denial of Service

Vulnerability

CVE-2026-46597 is a Denial of Service vulnerability in golang.org/x/crypto/ssh caused by crafted AES-GCM packet decoder inputs. An attacker could exploit malformed SSH packets to crash or hang the server.

Remediation steps

  1. Replaced golang.org/x/crypto with a patched fork: Added a replace directive in go.mod to pin golang.org/x/crypto to github.com/openshift-sustaining/crypto v0.33.0-sec.4, which contains the fix for CVE-2026-46597.

  2. Bumped transitive golang.org/x/ dependencies to compatible versions required by the patched crypto module:

    • golang.org/x/crypto: v0.14.0 -> v0.23.0 (replaced by patched fork)
    • golang.org/x/net: v0.17.0 -> v0.25.0
    • golang.org/x/sys: v0.13.0 -> v0.30.0
    • golang.org/x/text: v0.13.0 -> v0.22.0
    • golang.org/x/tools: v0.12.0 -> v0.21.1
  3. Regenerated vendor directory: Ran go mod tidy && go mod vendor to sync all vendored dependencies with the updated go.mod.

  4. Fixed test infrastructure to unblock CI after the dependency update:

    • test-backend.sh: Scoped the git status vendor consistency check to vendor/, go.mod, and go.sum only. The previous git status --porcelain --ignored was picking up unrelated ignored directories (e.g. node_modules/, .claude/), causing false positives.
    • build-i18n.sh: Resolved the i18next binary path absolutely using the script's directory. Yarn 4 does not inject node_modules/.bin into PATH for child shell processes, so the bare i18next command was not found.
  5. Regenerated i18n locale files: Updated all frontend locale JSON files to reflect the current state of translation keys.

Test plan

  • ./test.sh passes end-to-end (backend, frontend, demos)
  • Backend: vendor consistency check, Go tests, gofmt, govet all pass
  • Frontend: i18n check, yarn dedupe check, eslint, and 589 test suites (4063 tests) all pass
  • Demos: dynamic-demo-plugin yarn.lock check passes

tonyxrmdavidson and others added 3 commits August 12, 2026 11:30
…ypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.15.z]
Scope git status in test-backend.sh to vendor/go.mod/go.sum to avoid
false positives from ignored directories. Resolve i18next binary path
in build-i18n.sh so it works under Yarn 4. Regenerate i18n locale files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c09fc34c-93a9-4a56-bd98-7babda90fee0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from TheRealJon and rhamilto August 12, 2026 12:25
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Aug 12, 2026
@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tonyxrmdavidson
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 12, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-92747, which is invalid:

  • expected Jira Issue OCPBUGS-92747 to depend on a bug targeting a version in 4.16.0, 4.16.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-92747: CVE-2026-46597 — golang.org/x/crypto/ssh Denial of Service

Vulnerability

CVE-2026-46597 is a Denial of Service vulnerability in golang.org/x/crypto/ssh caused by crafted AES-GCM packet decoder inputs. An attacker could exploit malformed SSH packets to crash or hang the server.

Remediation steps

  1. Replaced golang.org/x/crypto with a patched fork: Added a replace directive in go.mod to pin golang.org/x/crypto to github.com/openshift-sustaining/crypto v0.33.0-sec.4, which contains the fix for CVE-2026-46597.

  2. Bumped transitive golang.org/x/ dependencies to compatible versions required by the patched crypto module:

  • golang.org/x/crypto: v0.14.0 -> v0.23.0 (replaced by patched fork)
  • golang.org/x/net: v0.17.0 -> v0.25.0
  • golang.org/x/sys: v0.13.0 -> v0.30.0
  • golang.org/x/text: v0.13.0 -> v0.22.0
  • golang.org/x/tools: v0.12.0 -> v0.21.1
  1. Regenerated vendor directory: Ran go mod tidy && go mod vendor to sync all vendored dependencies with the updated go.mod.

  2. Fixed test infrastructure to unblock CI after the dependency update:

  • test-backend.sh: Scoped the git status vendor consistency check to vendor/, go.mod, and go.sum only. The previous git status --porcelain --ignored was picking up unrelated ignored directories (e.g. node_modules/, .claude/), causing false positives.
  • build-i18n.sh: Resolved the i18next binary path absolutely using the script's directory. Yarn 4 does not inject node_modules/.bin into PATH for child shell processes, so the bare i18next command was not found.
  1. Regenerated i18n locale files: Updated all frontend locale JSON files to reflect the current state of translation keys.

Test plan

  • ./test.sh passes end-to-end (backend, frontend, demos)
  • Backend: vendor consistency check, Go tests, gofmt, govet all pass
  • Frontend: i18n check, yarn dedupe check, eslint, and 589 test suites (4063 tests) all pass
  • Demos: dynamic-demo-plugin yarn.lock check passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/test backend

2 similar comments
@tonyxrmdavidson

Copy link
Copy Markdown
Author

/test backend

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/test backend

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@tonyxrmdavidson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 010d947 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants