OCPBUGS-77113: remove dev to admin links as dev monitoring views are enabled

[jgbernalp]

Summary by CodeRabbit

• Updates
  • Monitoring dashboard URLs now use path-based routing instead of query parameters.
  • Monitoring access is now controlled by feature flags and user permissions.
  • Added perspective-aware navigation behavior for monitoring views and alerts.
  • The application automatically adjusts your perspective when navigating to specific monitoring dashboards.

[openshift-ci-robot]

@jgbernalp: This pull request references Jira Issue OCPBUGS-77113, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgbernalp
Once this PR has been reviewed and has the lgtm label, please assign vojtechszocs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request refactors monitoring URL routing across multiple OpenShift Console components to support perspective-aware navigation. Changes replace query-parameter-based monitoring URLs with path-encoded routes using /dev-monitoring/ns/{namespace}. The useActivePerspective hook is integrated to track the active perspective state, while a new canAccessMonitoring flag gates monitoring access by combining feature flag checks with Prometheus availability. Components now conditionally route to either standard monitoring query-browser or dev-monitoring paths based on perspective state and access permissions. OnClick handlers switch perspective to 'dev' when navigating to dev-monitoring URLs from other perspectives. The PrometheusGraphLinkProps interface is updated to expose the canAccessMonitoring boolean.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

Warning

Review ran into problems

🔥 Problems

Linked repositories: Couldn't analyze openshift/console - clone failed: Clone operation failed: Stream setup permanently failed: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@frontend/packages/console-shared/src/components/dashboard/utilization-card/TopConsumerPopover.tsx`:
- Around line 188-191: The monitoringURL construction in TopConsumerPopover
always interpolates the optional prop namespace, causing
/dev-monitoring/ns/undefined when namespace is missing; change the monitoringURL
logic (used with monitoringParams, canAccessMonitoring, activePerspective) to
only include `/ns/${namespace}/metrics` when namespace is truthy and otherwise
fall back to a safe path such as
`/dev-monitoring/metrics?${monitoringParams.toString()}` (or omit the ns segment
entirely), preserving the admin branch for `/monitoring/query-browser?...`.

In `@frontend/public/components/graphs/prometheus-graph.tsx`:
- Line 13: The import in prometheus-graph.tsx currently references the package
internal path '@console/dynamic-plugin-sdk/src'; update the import to use the
package entrypoint '@console/dynamic-plugin-sdk' instead so useActivePerspective
is imported from the public API (replace the import that references '/src' with
the package root import for useActivePerspective).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 31957c53-4854-4931-ba48-795c5962bedc

📥 Commits

Reviewing files that changed from the base of the PR and between 458a8b6 and d166ad1.

📒 Files selected for processing (5)

• frontend/packages/console-shared/src/components/dashboard/utilization-card/TopConsumerPopover.tsx
• frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardGraph.tsx
• frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverview.tsx
• frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverviewAlerts.tsx
• frontend/public/components/graphs/prometheus-graph.tsx

📜 Review details

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverview.tsx
• frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverviewAlerts.tsx
• frontend/public/components/graphs/prometheus-graph.tsx
• frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardGraph.tsx
• frontend/packages/console-shared/src/components/dashboard/utilization-card/TopConsumerPopover.tsx

[openshift-ci]

@jgbernalp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	d6ef276	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.