Skip to content

CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs#15254

Merged
openshift-merge-bot[bot] merged 7 commits intoopenshift:mainfrom
logonoff:CONSOLE-4499-codeeditor-electric-boogaloo
Jul 16, 2025
Merged

CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs#15254
openshift-merge-bot[bot] merged 7 commits intoopenshift:mainfrom
logonoff:CONSOLE-4499-codeeditor-electric-boogaloo

Conversation

@logonoff
Copy link
Copy Markdown
Member

@logonoff logonoff commented Jul 7, 2025 •
edited
Loading

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 7, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

  • Added a copy to clipboard button
  • Added fullscreen button
  • Added ability to toggle sticky scroll
  • Refactored edit-yaml to typescript
Screencast.From.2025-07-07.10-58-38.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 7, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

  • Added a copy to clipboard button
  • Added fullscreen button
  • Added ability to toggle sticky scroll
  • Refactored edit-yaml to typescript
Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and jhadvig July 7, 2025 21:11
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 7, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 8, 2025
@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch 2 times, most recently from 412fcf8 to b8a275b Compare July 8, 2025 15:31
@logonoff logonoff changed the title CONSOLE-4499: Implement some CodeEditor RFEs (WIP) CONSOLE-4499, CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) Jul 8, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 8, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title CONSOLE-4499, CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) Jul 8, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 8, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch from 218e928 to 0c4b0ed Compare July 8, 2025 19:36
@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Jul 8, 2025

code review:
/assign @rhamilto

qe review:
/assign @yapei

px approval:
/assign @sferich888

docs approval:
/assign @opayne1

@logonoff logonoff changed the title CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs Jul 9, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 9, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 9, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 9, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanpzhan
Copy link
Copy Markdown
Contributor

yanpzhan commented Jul 9, 2025

@logonoff I noticed that in fullscreen mode, the 'Save', 'Reload', 'Cancel' button and sidebar button all could be clicked with reaction, but other buttons had no response when click, eg, 'Copy code to clipboard', 'Edit setting', 'Ask OpenShift Lightspeed'. Do you think if this is an issue?
Screenshot from 2025-07-09 19-18-05

@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch 2 times, most recently from da14b21 to 8aea356 Compare July 9, 2025 13:20
@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Jul 9, 2025

@logonoff I noticed that in fullscreen mode, the 'Save', 'Reload', 'Cancel' button and sidebar button all could be clicked with reaction, but other buttons had no response when click, eg, 'Copy code to clipboard', 'Edit setting', 'Ask OpenShift Lightspeed'. Do you think if this is an issue?

Hey, those are indeed issues.. I found that "Copy code to clipboard" worked fine, but settings and OpenShift lightspeed didn't. I fixed the settings button but couldn't find a good fix for Lightspeed, so instead I disabled the lightspeed button when the editor is fullscreen.

@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch from 62c0e09 to ccd4ecf Compare July 15, 2025 12:19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
@Mylanos
Copy link
Copy Markdown
Contributor

Mylanos commented Jul 15, 2025

/test frontend

@Mylanos
Copy link
Copy Markdown
Contributor

Mylanos commented Jul 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2025
@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch from 8d9e1ae to 0eb4740 Compare July 16, 2025 11:06
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2025
@Mylanos
Copy link
Copy Markdown
Contributor

Mylanos commented Jul 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, Mylanos, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 16, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Jul 16, 2025

/tide refresh
/retest

@openshift-merge-bot openshift-merge-bot bot merged commit a691e64 into openshift:main Jul 16, 2025
7 checks passed
@logonoff logonoff deleted the CONSOLE-4499-codeeditor-electric-boogaloo branch July 16, 2025 20:03
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 17, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202507162215.p0.ga691e64.assembly.stream.el9.
All builds following this will include this PR.

@rhamilto rhamilto mentioned this pull request Jul 18, 2025
Merged
@vojtechszocs vojtechszocs mentioned this pull request Aug 14, 2025
Merged
vojtechszocs added a commit to vojtechszocs/console that referenced this pull request Aug 14, 2025
@vojtechszocs
List all user impacting changes from openshift#15254
3ee4eba
vojtechszocs added a commit to vojtechszocs/console that referenced this pull request Aug 14, 2025
@vojtechszocs
List all user impacting changes from openshift#15254
8b57551
@logonoff logonoff mentioned this pull request Oct 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cajieh cajieh Awaiting requested review from cajieh

@jhadvig jhadvig Awaiting requested review from jhadvig

1 more reviewer

@Mylanos Mylanos Mylanos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vojtechszocs vojtechszocs

@rhamilto rhamilto

@spadgett spadgett

@sferich888 sferich888

@jhadvig jhadvig

@yapei yapei

@Mylanos Mylanos

@opayne1 opayne1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer plugin-api-changed Categorizes a PR as containing plugin API changes px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.