CNF-15505: Set crun as the default runtime #1180
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rbaturov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
rbaturov
force-pushed
the
ensure-crun-default
branch
from
284eede
to
8b1e2bd
Compare
|
/test all |
rbaturov
force-pushed
the
ensure-crun-default
branch
from
8b1e2bd
to
b4005ab
Compare
|
/test all |
|
/test e2e-gcp-pao e2e-gcp-pao-updating-profile e2e-hypershift-pao e2e-gcp-pao-workloadhints |
|
/test e2e-gcp-pao |
|
/test all |
rbaturov
force-pushed
the
ensure-crun-default
branch
from
417a969
to
38742f8
Compare
|
/test all |
rbaturov
force-pushed
the
ensure-crun-default
branch
2 times, most recently
from
cba201d
to
aabe6e0
Compare
|
/test all |
rbaturov
force-pushed
the
ensure-crun-default
branch
from
aabe6e0
to
fb7ea90
Compare
|
/test all |
rbaturov
force-pushed
the
ensure-crun-default
branch
from
fb7ea90
to
0e2c4b5
Compare
|
/test all |
rbaturov
force-pushed
the
ensure-crun-default
branch
from
0e2c4b5
to
0176178
Compare
|
/test all |
This logic is unnecessary. I've tested this patch and found no need for it. Signed-off-by: Ronny Baturov <[email protected]>
Starting with OCP 4.18, crun is the default container runtime. The operator should align with this and treat crun as the default runtime. The updated logic will be as follows: * If no ContainerRuntimeConfig is applied, crun will be used by default. * If a ContainerRuntimeConfig is applied and explicitly requests runc, then switch to runc. Signed-off-by: Ronny Baturov <[email protected]>
* Use crun as the default runtime for rendering * Commit make render-sync Signed-off-by: Ronny Baturov <[email protected]>
Signed-off-by: Ronny Baturov <[email protected]>
rbaturov
force-pushed
the
ensure-crun-default
branch
from
0176178
to
4c5df3d
Compare
|
/test all |
|
@rbaturov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
rbaturov
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@rbaturov: This pull request references CNF-15505 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Previously, to select the container runtime for high-performance class, we checked for an existing ContainerRuntimeConfig. If none was found, the default runtime was used. However, starting with OCP 4.18, the default runtime switches to crun, meaning that systems upgrading from OCP 4.17 to 4.18 would experience an unintended runtime switch under the hood. To prevent this, the MCO team introduced a patch in OCP 4.17 to create a default machine config for all MCP's, explicitly setting runc as the runtime. As a result, we need to adjust our logic to identify this MachineConfig when no ContainerRuntimeConfig is found. Signed-off-by: Ronny Baturov <[email protected]>
Starting with OCP 4.18, crun is the default container runtime. The operator should align with this and treat crun as the default runtime.
The updated logic will be as follows:
ContainerRuntimeConfigis applied,crunwill be used by default.ContainerRuntimeConfigis applied and explicitly requestsrunc, then switch torunc.Note:
There is an edge case that raises a concern about this work:
A system upgrade from OCP 4.17 (with performance profile applied and no
ContainerRuntimeConfig) to 4.18 will result with the container runtime switch tocrununder the hood.