Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: One shot tuning must start after irqbalance cleanup #1164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: One shot tuning must start after irqbalance cleanup #1164

wants to merge 1 commit into from

Conversation

MarSik
Copy link
Contributor

@MarSik MarSik commented Sep 16, 2024

This fixes a potential race condition between the two early services:

  • clear-irqbalance-banned-cpus.service
  • ocp-tuned-one-shot.service

@MarSik
One shot tuning must start after irqbalance cleanup
1be6e9d 
This fixes a potential race condition between the two early services:

- clear-irqbalance-banned-cpus.service
- ocp-tuned-one-shot.service
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@jmencak
Copy link
Contributor

jmencak commented Sep 16, 2024

local test failing, perhaps make render-sync ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

@MarSik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao 1be6e9d link true /test e2e-gcp-pao
ci/prow/e2e-hypershift-pao 1be6e9d link true /test e2e-hypershift-pao
ci/prow/e2e-no-cluster 1be6e9d link true /test e2e-no-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak Awaiting requested review from jmencak

@rbaturov rbaturov Awaiting requested review from rbaturov

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarSik @jmencak