feat: add basic support for multicluster env in MCP #71
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pkg/mcp/incidents_tool.go
Outdated
| clusterName := v.Metric["cluster"] | ||
| clusterID := v.Metric["clusterID"] |
There was a problem hiding this comment.
- Backward compatibility: what happens if the labels are not present?
- string() is applied here for some labels, and later for others. I would stringify all in the same place, for consistency
There was a problem hiding this comment.
Backward compatibility: what happens if the labels are not present?
empty string
|
@tremes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
3 participants
No description provided.