Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow concurrency to be a list of values to iterate over #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow concurrency to be a list of values to iterate over #58

wants to merge 4 commits into from

Conversation

dagrayvid
Copy link
Collaborator

No description provided.

@dagrayvid dagrayvid force-pushed the concurrency-list branch 2 times, most recently from 35d7062 to adb73e3 Compare October 19, 2024 18:55
ccamacho
ccamacho approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@ccamacho ccamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, im currently using a bash loop with multiple configuration files (different concurrency values) when running my tests so this will be a nice addition.

sjmonson
sjmonson suggested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the prompt formatting from this PR. Do we still want it or should we remove the feature entirely?

sjmonson
sjmonson suggested changes Nov 4, 2024
View reviewed changes
build/Pod.yaml Outdated
spec:
containers:
- name: llm-load-test
image: quay.io/dagray/llm-load-test:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quay repo seems out of date; can you set up an automatic build trigger?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely look into this, and move it out of my personal quay repository

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I removed the reference to this specific image. We should set up an automatic build trigger.

config.yaml Outdated Show resolved Hide resolved
utils.py Outdated Show resolved Hide resolved
@dagrayvid dagrayvid changed the title WIP: Allow concurrency to be a list of values to iterate over Allow concurrency to be a list of values to iterate over Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmonson sjmonson sjmonson requested changes

@ccamacho ccamacho ccamacho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagrayvid @ccamacho @sjmonson