Clearification About GitOps Command Execution on Pushed Commits #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakisk
force-pushed
the
clearification-on-gitops-pushed-commit-head
branch
from
25865db to
c53cd76
Compare
|
/test |
chmouel
reviewed
Feb 6, 2025
pkg/provider/github/github.go
Outdated
| @@ -600,5 +600,5 @@ func (v *Provider) isBranchContainsCommit(ctx context.Context, runevent *info.Ev | |||
| if branchInfo.Commit.GetSHA() == runevent.SHA { | |||
| return nil | |||
| } | |||
| return fmt.Errorf("provided branch %s does not contains sha %s", branchName, runevent.SHA) | |||
| return fmt.Errorf("provided sha %s is not HEAD commit of branch %s", runevent.SHA, branchName) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("provided sha %s is not HEAD commit of branch %s", runevent.SHA, branchName) | |
| return fmt.Errorf("provided SHA %s is not the HEAD commit of the branch %s", runevent.SHA, branchName) |
The changes:
- Capitalized "SHA" as it's an acronym
- Added "the" before "HEAD commit"
- Added "the" before "branch"
|
thanks, just a minor phrasing and good to go |
zakisk
force-pushed
the
clearification-on-gitops-pushed-commit-head
branch
from
c53cd76 to
5c72931
Compare
|
/test go-testing |
in docs it was not specified that GitOps command on pushed commit only works on latest HEAD commit and does not trigger PipelineRun if sent on older commits. Signed-off-by: Zaki Shaikh <[email protected]>
zakisk
force-pushed
the
clearification-on-gitops-pushed-commit-head
branch
from
5c72931 to
f9145ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in docs it was not specified that GitOps command on pushed commit only works on latest HEAD commit and does not trigger PipelineRun if sent on older commits.
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the documentation accordingly)