-
Notifications
You must be signed in to change notification settings - Fork 22
SRVKP-5501: feat: Implement support for Task spec.displayName
#331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SRVKP-5501: feat: Implement support for Task spec.displayName
#331
Conversation
Skipping CI for Draft Pull Request. |
@vikram-raj Do you mind reviewing when you are able? |
Co-authored-by: Vikram Raj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list page uses spec.displayName
, whereas the details page uses metadata.name
as a user it looks broken because of difference in name. As this is a feature, can you confirm it with PM/UX?
Add task details page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lokanandaprabhu IMO, we should show displayName here if it is available in TR. wdyt @aThorp96 ? |
@vikram-raj @lokanandaprabhu in that view the This column could be changed to fallback on the Task's Display Name via the TaskRun's annotation |
@aThorp96 @lokanandaprabhu, in my opinion, let's go with Task |
spec.displayName
spec.displayName
@aThorp96: This pull request references SRVKP-5501 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aThorp96, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest |
@aThorp96: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Implements https://issues.redhat.com/browse/SRVKP-5501