Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for allocations #13

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Add support for allocations #13

merged 1 commit into from
Apr 22, 2019

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Apr 9, 2019 •
edited
Loading

Add support for allocations

stbenjam
stbenjam commented Apr 9, 2019
View reviewed changes
README.md Show resolved Hide resolved
@stbenjam
Copy link
Member Author

stbenjam commented Apr 9, 2019

@dtantsur Could you have a look if you have a minute?

@stbenjam stbenjam force-pushed the allocations branch 2 times, most recently from 2d12a90 to 0acd5cc Compare April 9, 2019 17:01
dtantsur
dtantsur reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline. Also I'd highly prefer this PR to be split into 3, since currently it's barely reviewable.

ironic/resource_ironic_allocation_v1.go Outdated Show resolved Hide resolved
ironic/resource_ironic_allocation_v1.go Outdated Show resolved Hide resolved
ironic/resource_ironic_node_v1.go Outdated Show resolved Hide resolved
@stbenjam
Copy link
Member Author

Sure, vendoring is pretty ugly. That change is here: #14

I'm splitting out power state, as well. This PR will have to go last, and tests will fail until both are merged.

@stbenjam
Copy link
Member Author

Power state PR is here: #15

@stbenjam
Copy link
Member Author

I'll rebase this one once the others are merged.

dtantsur
dtantsur requested changes Apr 11, 2019
View reviewed changes
README.md Show resolved Hide resolved
ironic/provider.go Show resolved Hide resolved
ironic/resource_ironic_node_v1.go Outdated Show resolved Hide resolved
@stbenjam stbenjam force-pushed the allocations branch 4 times, most recently from ce997ae to 1021e80 Compare April 15, 2019 12:56
@stbenjam
Copy link
Member Author

stbenjam commented Apr 15, 2019 •
edited
Loading

I filed #18, I'll open a separate PR to handle microversions as recommended for a high-level SDK.

This should be ready for another look.

@stbenjam
Copy link
Member Author

Going to merge this, can iterate on next PR if anything needs changing.

@stbenjam stbenjam merged commit 31826d6 into openshift-metal3:master Apr 22, 2019
@stbenjam stbenjam deleted the allocations branch April 22, 2019 16:48
@stbenjam stbenjam mentioned this pull request Apr 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stbenjam @dtantsur