NO-ISSUE: Renable xtrace for agent/06_agent_create_cluster.sh #1771
Conversation
xtrace was inadvertently disabled in openshift-metal3#1745 This patch moves the getRendezvousIP function out of e2e/agent-tui/utils.sh and into common.sh. e2e/agent-tui/utils.sh contains "set +x" which disables xtrace. 06_agent_create_cluster.sh no longer sources e2e/agent-tui/util.sh so that it doesn't inherit the "set +x" call.
|
@rwsu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
xtrace was inadvertently disabled in
#1745
This patch moves the getRendezvousIP function out of e2e/agent-tui/utils.sh and into common.sh.
e2e/agent-tui/utils.sh contains "set +x" which disables xtrace.
06_agent_create_cluster.sh no longer sources e2e/agent-tui/util.sh so that it doesn't inherit the "set +x" call.