Skip to content

Conversation

@maschmid
Copy link

@maschmid maschmid commented Oct 2, 2025

See opencontainers/runc#4772 , tldr; runc changed how the cpu.weight is calculated, so the test now fails.

We introduce the alternative formula and let the test pass if either of the formulas match the cpu.weight value.

@openshift-ci openshift-ci bot requested review from Fedosin and mvinkler October 2, 2025 15:25
@openshift-ci openshift-ci bot added the approved label Oct 2, 2025
@maschmid maschmid force-pushed the maschmid-release-v1.17-cgroups-cpu-weight-alternate-formula branch from 21a9c76 to d9f82b7 Compare October 2, 2025 15:46
@dsimansk
Copy link

dsimansk commented Oct 2, 2025

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 841467b into openshift-knative:release-v1.17 Oct 2, 2025
35 checks passed
@maschmid
Copy link
Author

maschmid commented Oct 3, 2025

/cherry-pick release-v1.18
/cherry-pick release-v1.16

@openshift-cherrypick-robot

@maschmid: new pull request created: #1595

In response to this:

/cherry-pick release-v1.18
/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@maschmid: new pull request created: #1597

In response to this:

/cherry-pick release-v1.18
/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants