Adjust expected timeout message and accept regex in expected message #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2023
This was referenced Sep 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the pipeline for #254
The reason for the failure is because in scenario
HC-16_chart_test_takes_more_than_30minsfor partners, we're expecting the string* timed out waiting for the conditionin the PR comment. The time out does occur, and the PR does get a comment about a timeout, but it doesn't contains this exact string.This is the PR in question FYI: openshift-helm-charts/sandbox#65858
I dug around but I can't seem to understand how this was passing until now. They were a few recent changes that could have affected this, but I must be missing something because I can't find the culprit: