Skip to content

Conversation

@clobrano
Copy link
Contributor

@clobrano clobrano commented Aug 4, 2025

The script continuously monitors both Pacemaker (PCS) status and etcd member list by automatically switching between available cluster nodes when connectivity issues occur.

It includes intelligent node discovery from inventory files or virsh.

@openshift-ci openshift-ci bot requested review from jeff-roche and qJkee August 4, 2025 16:32
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@dhensel-rh
Copy link
Contributor

@clobrano A quick note. Since this is a shell script, could the file be named to include the .sh extension please ?

@clobrano
Copy link
Contributor Author

clobrano commented Aug 5, 2025

@clobrano A quick note. Since this is a shell script, could the file be named to include the .sh extension please ?

Sure, no problem

@clobrano clobrano force-pushed the helper/watch-pcs-and-etcd branch 2 times, most recently from f0dcd4b to 8ced449 Compare August 5, 2025 08:24
@clobrano
Copy link
Contributor Author

clobrano commented Aug 5, 2025

I need to review the check that makes the script switch to the next node

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
The script continuously monitors both Pacemaker (PCS) status and etcd
member list by automatically switching between available cluster nodes
when connectivity issues occur.

It includes intelligent node discovery from inventory files or virsh.
@clobrano clobrano force-pushed the helper/watch-pcs-and-etcd branch from 8ced449 to 1547da4 Compare August 5, 2025 10:55
@clobrano
Copy link
Contributor Author

clobrano commented Aug 5, 2025

I fixed the problem

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
@clobrano
Copy link
Contributor Author

clobrano commented Aug 13, 2025

The automatic nodes recognition via virsh is a bit flaky

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@fonta-rh
Copy link
Contributor

I was creating another PR when I saw this one, and I was thinking, @clobrano want me to add an Ansible version that uses the inventory to access the VMs? They're added automatically in TNT after cluster installation

@clobrano
Copy link
Contributor Author

Let me update the script, in case I added any fix meanwhile, then yes, it could be helpful to use a playbook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants